1440413 - Double-click in the upper part of the content area maximizes/minimized the window

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: screencast

Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 ID:20180222154733

STR:
1. Open Firefox.
2. Double-click in the upper part of the content area (just somewhere below the address bar).
3. The window maximizes/minimizes.

I think this started after bug 1417847. Is that possible, or should I start looking for a regression window?

Comment 1

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Confirmed with mozregression https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ad3678a2943b860a240de123dc57520cf622572c&tochange=e7b57f8eeec3e00a8ffd27d9458ff697f3f0b5a9.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Hm, I wonder if we get wrong drag area or we miss some offset here. We may also consider to disable it when drawing to titlebar is disabled.

Comment 3

[Jan Horak [:jhorak]]

Thanks for the report, what theme do you use (gtk and mozilla)?

Comment 4

[Hideo Oshima]

I can also reproduce.
GTK2/3 theme is adwaita and Firefox theme is Default.

Comment 5

[Jan Horak [:jhorak]]

Attachment: Bug 1440413 - Use original mouse event position when checking for doubleclick on titlebar;

The DispatchEvent can manipulate with the mRefPoint we're later using to check if the
double click happened on the titlebar. We need to save it for later check to avoid
unwanted restore/maximize event when mouse event occurs near top border of any widget.

Review commit: https://reviewboard.mozilla.org/r/223180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223180/

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8954030 [details]
Bug 1440413 - Use original mouse event position when checking for doubleclick on titlebar;

https://reviewboard.mozilla.org/r/223180/#review229126

::: widget/gtk/nsWindow.cpp:2822
(Diff revision 1)
>  
>      bool defaultPrevented = (eventStatus == nsEventStatus_eConsumeNoDefault);
>      // Check if mouse position in titlebar and doubleclick happened to
>      // trigger restore/maximize.
> -    LayoutDeviceIntPoint pos = event.mRefPoint;
>      if (!defaultPrevented

Please also enable the doubleclick maximize only when titlebar rendering is actually enabled.

Comment 7

[Jan Horak [:jhorak]]

Comment on attachment 8954030 [details]
Bug 1440413 - Use original mouse event position when checking for doubleclick on titlebar;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223180/diff/1-2/

Comment 8

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I have Nightly downloaded from archive.mozilla.org. Theme built-in Dark with compact density. Running Fedora 27 without any theme tweaks, with the exception of "No title bar" extension, but that shouldn't do anything to apps with CSD enabled.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8954030 [details]
Bug 1440413 - Use original mouse event position when checking for doubleclick on titlebar;

https://reviewboard.mozilla.org/r/223180/#review229484

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59daaec35ff1
Use original mouse event position when checking for doubleclick on titlebar; r=stransky

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/59daaec35ff1

Comment 12

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Seems to work fine in Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 ID:20180228100110.