1440430 - Remove --without-gradle configure option

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

This tracks removing --without-gradle entirely, and dropping all of the places that we switch on MOZ_BUILD_MOBILE_ANDROID_WITH_GRADLE.  It's not necessarily the same as removing the moz.build definitions from mobile/android/base in https://bugzilla.mozilla.org/show_bug.cgi?id=1255924.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1440430: Disable --without-gradle configure option.

We don't remove the configure option entirely for two reasons:

1) --with-gradle is still used in automation to specify a particular
Gradle binary, which is functionality we want to keep;

2) developers might have --with-gradle specified, and we can save them
having to remove it explicitly.

Review commit: https://reviewboard.mozilla.org/r/222476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222476/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8953193 [details]
Bug 1440430: Disable --without-gradle configure option.

https://reviewboard.mozilla.org/r/222476/#review228434

::: commit-message-c373f:8
(Diff revision 1)
> +2) developers might have --with-gradle specified, and we can save them
> +having to remove it explicitly.

For what it's worth this has a downside, too, because older mozconfigs that have lots of options in them that have since become defaults can be harder to debug.

::: mobile/android/gradle.configure:8
(Diff revision 1)
>  # Gradle binary is specified, or if --without-gradle is specified, use the in
>  # tree Gradle wrapper.  The wrapper downloads and installs Gradle, which is

This comment might want a tweak with this change.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8953193 [details]
Bug 1440430: Disable --without-gradle configure option.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222476/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c59239cde97d
Disable --without-gradle configure option. r=chmanchester

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c59239cde97d