Status

()

enhancement
P2
normal
RESOLVED FIXED
Last year
3 months ago

People

(Reporter: adrian17, Assigned: adrian17)

Tracking

(Blocks 1 bug)

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(2 attachments)

No description provided.
Assignee

Updated

Last year
Blocks: 1387169
Assignee

Updated

Last year
Assignee: nobody → adrian.wielgosik
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Priority: -- → P2

Comment 3

Last year
mozreview-review
Comment on attachment 8953201 [details]
Bug 1440441 - Remove nsIDOMFormData.

https://reviewboard.mozilla.org/r/222484/#review228754

::: js/xpconnect/src/Sandbox.cpp:958
(Diff revision 1)
> +        } else if (!strcmp(name.ptr(), "FormData")) {
> +            FormData = true;

Please keep this list sorted.

::: js/xpconnect/src/Sandbox.cpp:1049
(Diff revision 1)
> +    if (FormData &&
> +        !dom::FormDataBinding::GetConstructorObject(cx))
> +        return false;

Sorted here too, please.

::: js/xpconnect/src/xpcprivate.h:2696
(Diff revision 1)
>      bool TextDecoder : 1;
>      bool TextEncoder : 1;
>      bool URL : 1;
>      bool URLSearchParams : 1;
>      bool XMLHttpRequest : 1;
> +    bool FormData : 1;

And here.

::: toolkit/crashreporter/CrashSubmit.jsm:9
(Diff revision 1)
>  
>  ChromeUtils.import("resource://gre/modules/Services.jsm");
>  ChromeUtils.import("resource://gre/modules/FileUtils.jsm");
>  ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
>  ChromeUtils.import("resource://gre/modules/KeyValueParser.jsm");
> -Cu.importGlobalProperties(["File", "XMLHttpRequest"]);
> +Cu.importGlobalProperties(["File", "XMLHttpRequest", "FormData"]);

Sorted, please.
Attachment #8953201 - Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request)
Assignee

Updated

Last year
Keywords: checkin-needed
There is a single use in comm-central mail code that will need updating here:

https://searchfox.org/comm-central/source/mail/components/cloudfile/nsBox.js#781
Flags: needinfo?(jorgk)

Comment 6

Last year
Thanks for the heads-up. So we use:
Cu.importGlobalProperties(["File", "FormData", "XMLHttpRequest"]);
and
let form = new FormData();
?

I'll file a bug for that (leaving NI for now).
Yes, that should do it. (Importing `FormData` will only be possible after this patch gets merged, though.)

Comment 8

Last year
Adrian, if you don't mind, I'd like to attach a C-C patch in this bug, too (please let me know if you do). It would be nice if you could review it as well (2 lines). Thanks in advance. I'll take care of landing it when the time comes.
Flags: needinfo?(jorgk)
Attachment #8953775 - Flags: review?(adrian.wielgosik)
Comment on attachment 8953775 [details] [diff] [review]
1440441-comm-central.patch (M-C sheriff: Please do *not* land).

Review of attachment 8953775 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK, but untested.
Attachment #8953775 - Flags: review?(adrian.wielgosik) → review+

Comment 11

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/7744443168b8
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla60

Comment 12

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/185a8711571f
comm-central part: Remove use of nsIDOMFormData. r=adrian17
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.