1440441 - Remove nsIDOMFormData

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1440441 - Remove nsIDOMFormData.

Review commit: https://reviewboard.mozilla.org/r/222484/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222484/

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8953201 [details]
Bug 1440441 - Remove nsIDOMFormData.

https://reviewboard.mozilla.org/r/222484/#review228484

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8953201 [details]
Bug 1440441 - Remove nsIDOMFormData.

https://reviewboard.mozilla.org/r/222484/#review228754

::: js/xpconnect/src/Sandbox.cpp:958
(Diff revision 1)
> +        } else if (!strcmp(name.ptr(), "FormData")) {
> +            FormData = true;

Please keep this list sorted.

::: js/xpconnect/src/Sandbox.cpp:1049
(Diff revision 1)
> +    if (FormData &&
> +        !dom::FormDataBinding::GetConstructorObject(cx))
> +        return false;

Sorted here too, please.

::: js/xpconnect/src/xpcprivate.h:2696
(Diff revision 1)
>      bool TextDecoder : 1;
>      bool TextEncoder : 1;
>      bool URL : 1;
>      bool URLSearchParams : 1;
>      bool XMLHttpRequest : 1;
> +    bool FormData : 1;

And here.

::: toolkit/crashreporter/CrashSubmit.jsm:9
(Diff revision 1)
>  
>  ChromeUtils.import("resource://gre/modules/Services.jsm");
>  ChromeUtils.import("resource://gre/modules/FileUtils.jsm");
>  ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
>  ChromeUtils.import("resource://gre/modules/KeyValueParser.jsm");
> -Cu.importGlobalProperties(["File", "XMLHttpRequest"]);
> +Cu.importGlobalProperties(["File", "XMLHttpRequest", "FormData"]);

Sorted, please.

Comment 4

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8953201 [details]
Bug 1440441 - Remove nsIDOMFormData.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222484/diff/1-2/

Comment 5

[Adrian Wielgosik [:adrian17]]

There is a single use in comm-central mail code that will need updating here:

https://searchfox.org/comm-central/source/mail/components/cloudfile/nsBox.js#781

Comment 6

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up. So we use:
Cu.importGlobalProperties(["File", "FormData", "XMLHttpRequest"]);
and
let form = new FormData();
?

I'll file a bug for that (leaving NI for now).

Comment 7

[Adrian Wielgosik [:adrian17]]

Yes, that should do it. (Importing `FormData` will only be possible after this patch gets merged, though.)

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: 1440441-comm-central.patch (M-C sheriff: Please do *not* land).

Adrian, if you don't mind, I'd like to attach a C-C patch in this bug, too (please let me know if you do). It would be nice if you could review it as well (2 lines). Thanks in advance. I'll take care of landing it when the time comes.

Comment 9

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8953775 [details] [diff] [review]
1440441-comm-central.patch (M-C sheriff: Please do *not* land).

Review of attachment 8953775 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK, but untested.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7744443168b8
Remove nsIDOMFormData. r=kmag,qdot

Comment 11

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/7744443168b8

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/185a8711571f
comm-central part: Remove use of nsIDOMFormData. r=adrian17