1440467 - Add always-on push connection with pref control

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, enhancement)

Description

[Ben Bangert [:benbangert]]

A pref value should be added that controls whether the websocket connection for Push is opened even when there are no push subscriptions (always-on).


Rationale:

Currently, our Push service has had synthetic benchmarks showing its ability to handle 10 million concurrent connections. Our synthetic testing clients may not perfectly simulate the real Firefox clients and connection handling. We should have the ability to pref control whether the push connection channels is opened so that we can verify our ability to handle all Firefox clients connecting via either System Add-Ons or SHIELD.

Comment 1

[Lina Butler [:lina]]

I think this would involve changing https://searchfox.org/mozilla-central/rev/bd05e3853c6e982e2a35c1cc404b987b2bc914d6/dom/push/PushService.jsm#241-247 and https://searchfox.org/mozilla-central/rev/9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/dom/push/PushServiceWebSocket.jsm#515-521 to connect unconditionally if the pref is set.

Comment 2

[Lina Butler [:lina]]

Attachment: Bug 1440467 - Add a pref to always connect to the Push server without existing subscriptions.

Review commit: https://reviewboard.mozilla.org/r/222636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222636/

Comment 3

[Martin Thomson [:mt:]]

Comment on attachment 8953345 [details]
Bug 1440467 - Add a pref to always connect to the Push server without existing subscriptions.

https://reviewboard.mozilla.org/r/222636/#review228902

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6425eadbba7a
Add a pref to always connect to the Push server without existing subscriptions. r=mt

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6425eadbba7a