1440632 - Reader View icon is not constantly visible while scrolling up and down on some sites

Status: RESOLVED WORKSFORME

(Toolkit :: Reader Mode, defect, P3)

Description

[Bogdan Maris, Desktop QA]

[Affected versions]: 
- 60.0a1 (2018-02-18)

[Affected platforms]:
- Ubuntu 16.04 (x86 and x64)
- Ubuntu 14.04 x64
- Windows 10 x64

[Steps to reproduce]:
1. Launch Firefox
2. Go to https://www.yahoo.com/news/live-coverage-trumps-state-union-address-154038353.html
3. Scroll up and down the page

[Expected result]:
- The Reader View icon should be constantly visible on the page when scrolling.

[Actual result]:
- The Reader View icon appears and disappears randomly inside the page.

[Regression range]:
- Not a regression, I was able to reproduce this issue on old Nightly from 2016-07-12 as well (where the feature was first introduced).

[Additional notes]:
- Here is a screencast showing the issue: https://goo.gl/qRJJez

Comment 1

[:Gijs (he/him)]

Yeah, this will be because the scrolling presumably causes pageshow events, which make us re-check whether the page is readerable, and the output of that will change because the page content is also changing. Without more information I'm not convinced there's much we can do here, and it doesn't seem severe enough to warrant immediate investigation.

Comment 2

[Micah [:mtigley] (she/her)]

This seems to be fixed. Feel free to re-open if that's not the case.