1440648 - Need to handle JSTRY_FOR_OF in JSScript::hasLoops()?

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[André Bargull [:anba]]

JSScript::hasLoops() is currently only used for IonBuilder::makeInliningDecision(...) and makeInliningDecision(...) was modified in bug 1142669 to use different inlining heuristics when loops are present. At about the same time bug 1143194 added JSTRY_FOR_OF. And now I'm wondering if the modified heuristics should also apply to for-of loops?

Comment 1

[Jan de Mooij [:jandem]]

Yeah we probably should add it. Also there should probably be some kind of switch-statement or MOZ_ASSERT so if we add a new try note we will update that code.

Comment 2

[Ashley Hauck [:khyperia]]

Attachment: Add JSTRY_FOR_OF to JSScript::hasLoops, and guard against new JSTRY values.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 9002541 [details] [diff] [review]
Add JSTRY_FOR_OF to JSScript::hasLoops, and guard against new JSTRY values.

Review of attachment 9002541 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03537843fab2
Add JSTRY_FOR_OF to JSScript::hasLoops, and guard against new JSTRY values. r=jandem

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/03537843fab2