Closed Bug 1440648 Opened 2 years ago Closed Last year

Need to handle JSTRY_FOR_OF in JSScript::hasLoops()?

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: anba, Assigned: khyperia)

Details

Attachments

(1 file)

JSScript::hasLoops() is currently only used for IonBuilder::makeInliningDecision(...) and makeInliningDecision(...) was modified in bug 1142669 to use different inlining heuristics when loops are present. At about the same time bug 1143194 added JSTRY_FOR_OF. And now I'm wondering if the modified heuristics should also apply to for-of loops?
Yeah we probably should add it. Also there should probably be some kind of switch-statement or MOZ_ASSERT so if we add a new try note we will update that code.
Priority: -- → P3
Assignee: nobody → khyperia
Status: NEW → ASSIGNED
Attachment #9002541 - Flags: review?(jdemooij)
Comment on attachment 9002541 [details] [diff] [review]
Add JSTRY_FOR_OF to JSScript::hasLoops, and guard against new JSTRY values.

Review of attachment 9002541 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #9002541 - Flags: review?(jdemooij) → review+
Keywords: checkin-needed
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03537843fab2
Add JSTRY_FOR_OF to JSScript::hasLoops, and guard against new JSTRY values. r=jandem
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/03537843fab2
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.