1440663 - Don't let nsDocumentOpenInfo::DispatchContent indefinitely loop

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement, P2)

Description

[Honza Bambas (:mayhemer)]

See bug 1343536 comment 15.

The idea is to simply add a depth counter and let it be (preferable?) 20 max.  Then bail and forward to external helper.

The change would be somewhere around nsDocumentOpenInfo::ConvertData called from inside nsDocumentOpenInfo::DispatchContent

Comment 1

[Boris Zbarsky [:bzbarsky]]

We can do that as basically a workaround for broken converters, yeah...

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: v1

so, nsDocumentOpenInfo::ConvertData which creates a nested nsDocumentOpenInfo object keeps a counter that is there decreased on every new recursion.  the nice thing is that just throwing from inside nsDocumentOpenInfo::ConvertData will fall back to the external helper app service and ask the user to download or run an app for the content (we don't spit a cryptic error or silently fail).

a new pref added for it, defaults at 20: general.document_open_conversion_depth_limit

feel free to suggest a better name/namespace

Comment 3

[Honza Bambas (:mayhemer)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=edc3d4ea4594cdc2e58c530de9e0fbf822afc665

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9943503f940c
Add a preference to limit document opening data conversion recursion depth to nsDocumentOpenInfo, r=smaug

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9943503f940c