1440666 - With a download paused, tabs are restored

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Session Restore, defect, P5)

Description

[Oana Horvath [:ohorvath]]

Attachment: restored tabs logcat.txt

Devices: 
Samsung Galaxy Note 4 (Android 5.0.1)
LG G4 (Android 5.1)
Build: Nightly 60.0a1 (2018-02-23);

Steps to reproduce:
1. In Settings>Advanced menu, set Don't restore tabs when closing Fennec.
2. Go to https://www.thinkbroadband.com/download, download a large file and pause it.
3. Close Fennec and re-open Fennec.

Expected result:
Tabs should be closed.

Actual result:
Tabs are restored and they aren't loading. Logcat attached.

Comment 2

[Sorina Florean [:sflorean]]

Reproducible also if the downloads are in progress.

Comment 3

[Jan Henning [:JanH]]

and they aren't loading

sounds like bug 1494748.

As for

Tabs are restored

The problem is that the tab state is tied to the state of our main app process [1], whereas Android's task switcher deals with tasks as stacks of activities. Unless customised by an OEM, swiping away a task/activity won't kill the process as long as other activities or services are still using the process. For active (i.e. not completed) downloads, the latter case (we use a service for displaying the notification, so we won't be easily killed) probably applies.

While I grant that this is not ideal, I think that currently fixing this would be more trouble than its worth, as long as we finally manage to tackle bug 1494748.

[1] To which both the state of Gecko as well as that of our Tabs singleton instance are tied.

Comment 4

[miralobontiu]

I was able to reproduce the issue on Release 64.0.2, with Sony Xperia Z2 (Android 6.0.1).

Note:

• The restored tabs are blank. When I tried to reload the pages, the result was still blank pages.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.