1440757 - Don't invoke aapt in mobile/android/base/Makefile.in

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Nick Alexander :nalexander [he/him]]

Even after Bug 1440743, mobile/android/base/Makefile.in still invokes parts of the Android toolchain itself, most notably aapt.  And, in fact, it's required: at this time, the aapt invocation informs the Make dependency tree.  This ticket tracks flattening the Make dependencies and removing the aapt invocation.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1440757 - Don't invoke aapt in mobile/android/base/Makefile.in.

I choose to clean a bunch of ANDROID_* moz.build cruft here, too,
since it's just passing dependencies between moz.build and
Makefile.in.  The replacement for all of this is to just use
GENERATED_FILES in moz.build, but it'll still take some work to get to
that.  (Why does this stuff exist?  GENERATED_FILES didn't exist and
was resisted when I built this stuff.)

Review commit: https://reviewboard.mozilla.org/r/222812/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222812/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8953609 [details]
Bug 1440757 - Don't invoke aapt in mobile/android/base/Makefile.in.

https://reviewboard.mozilla.org/r/222812/#review229260

Good stuff!

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8953609 [details]
Bug 1440757 - Don't invoke aapt in mobile/android/base/Makefile.in.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222812/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b97e7bbe6b2
Don't invoke aapt in mobile/android/base/Makefile.in. r=jchen

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6b97e7bbe6b2