1440759 - links from push timestamp don't preserve filters because the format in the url parameter changed, no filters active

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Steps to reproduce:

1. Disable some of the circle filters left of the search box.
2. Reload the page (at the moment, the format of the links doesn't live update; also a regression afaik).
3. Copy the link from the timestamp of a push, e.g. https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1b6ba1c15366fb08dc376b403210615505422966&filter-resultStatus=testfailed,busted,exception,retry,usercancel,runnable
4. Open that link in a new tab.
Actual result: All filters disabled.
Expected result: Filters preserved.

Caused by:
Angular did this different: https://github.com/mozilla/treeherder/blame/c422eb968dd9c21af8fd01c4ad657fa4a1967784/ui/js/controllers/main.js#L675
Docs: https://docs.angularjs.org/api/ng/service/$httpParamSerializer

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3261

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/dec0e3caa154c1233505c28cb73eb09a70a994ca
Bug 1440759 - Preserve active filters in links from push timestamp. r?camd (#3261)