Closed
Bug 1440774
Opened 7 years ago
Closed 7 years ago
Convert Angular factories used for dependencies to ES6 imports
Categories
(Tree Management :: Treeherder: Frontend, enhancement, P1)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
We currently use AngularJS factories to `require()` various third-party packages - let's switch these to ES6 imports.
|
||
Comment 1•7 years ago
|
||
|
Assignee | |
Updated•7 years ago
|
Attachment #8953621 -
Flags: review?(cdawson)
|
||
Updated•7 years ago
|
Attachment #8953621 -
Flags: review?(cdawson) → review+
|
||
Comment 2•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/e095944a376b22c1c5a873a23f6a52f6d6178a2f
Bug 1440774 - Convert AngularJS dependency factories to ES6 imports (#3262)
Since it's the cleaner way to declare dependencies and is another
small step towards migrating away from AngularJS.
|
|
Assignee | |
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•7 years ago
|
||
This made quite a difference to the perf/logviewer bundle size:
* perf: 800KB -> 682KB
* logviewer: 650KB -> 532KB
Blocks: 1384255
You need to log in
before you can comment on or make changes to this bug.
Description
•