Closed Bug 1440774 Opened 6 years ago Closed 6 years ago

Convert Angular factories used for dependencies to ES6 imports

Categories

(Tree Management :: Treeherder: Frontend, enhancement, P1)

Product:
Tree Management
Component:
Treeherder: Frontend
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3262
47 bytes, text/x-github-pull-request
camd
: review+
Details | Review 
We currently use AngularJS factories to `require()` various third-party packages - let's switch these to ES6 imports.
Attachment #8953621 - Flags: review?(cdawson)
Attachment #8953621 - Flags: review?(cdawson) → review+
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e095944a376b22c1c5a873a23f6a52f6d6178a2f
Bug 1440774 - Convert AngularJS dependency factories to ES6 imports (#3262)

Since it's the cleaner way to declare dependencies and is another
small step towards migrating away from AngularJS.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
This made quite a difference to the perf/logviewer bundle size:
* perf: 800KB -> 682KB
* logviewer: 650KB -> 532KB
Blocks: 1384255
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: