1440784 - Show star icon for the top search result from bookmarks when typing into the address bar

Status: NEW

(Firefox :: Address Bar, defect, P5)

Description

[Rishabh Singla]

Attachment: Screenshot (1567).png

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180222170353

Steps to reproduce:

1) Configure FF to only show you results from bookmarks when you type into location bar [and not to show any search suggestions, open tabs or history links]
2) Open Incognito/Private window.
3) Start typing dogpile into the location bar [assuming 4 different dogpile URLs have already been bookmarked in FF].


Actual results:

You see all the 4 bookmarked URLs, but the top one doesn't show the star icon [which indicates that the given URL is in the bookmarks library]. You wonder whether this URL was bookmarked by you. You open all bookmarks to double-check.

Please look at the attached screenshot.


Expected results:

What's the point of not showing the star icon for the top result? It just seems weird and devoid of any logic. Please show star icon for top bookmark result too, to "reassure" the user.

Comment 1

[Marco Bonardo [:mak]]

This is expected because the first entry is an autofill entry based on known hosts, you may not have a bookmark specifically for that url, but you have  a bookmark for a page that has that host.
For that reason we didn't consider critical to show a star there.
We could maybe do that to reassure the user, as you said, but the number of users who disabled history is likely quite low, so this is not a priority. We'd probably accept a patch for it.