Closed Bug 1441010 Opened 7 years ago Closed 7 years ago

Body tag isn't closed in _generated_background_page.html

Categories

(WebExtensions :: Untriaged, enhancement, P5)

Product:
WebExtensions
Component:
Untriaged
Version:
60 Branch
Type:
enhancement

Tracking

(firefox60 wontfix, firefox61 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox60 --- wontfix
firefox61 --- fixed

People

(Reporter: fx4waldi, Assigned: bharatraghunthan9767, Mentored)

Details

(Whiteboard: good-first-bug)

Attachments

(1 file)

Bug 1441010 - Closed body tag
59 bytes, text/x-review-board-request
zombie
: review+
Details
Component: General → WebExtensions: Untriaged
Product: Firefox → Toolkit
Priority: -- → P5
Whiteboard: good-first-bug
If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started. Mentor: zombie
Mentor: tomica
I have read the guidelines as I am new to this. Can I take up this issue?
Hey Paarmita! Go for it! If you have any questions or need any help, needinfo :zombie. :)
Attachment #8962993 - Flags: review?(tomica)
Comment on attachment 8962993 [details] Bug 1441010 - Closed body tag https://reviewboard.mozilla.org/r/231834/#review237758 Thank you Paarmita, looks good.
Attachment #8962993 - Flags: review?(tomica) → review+
Sorry, that's "Thank you Bharat", I have Blind Reviews extension installed! ;)
Assignee: nobody → bharatraghunthan9767
And the Try looks green, let's land it.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0bdba6b45ceb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Congrats on landing this patch, Bharat! Your contribution has been added to our add-ons recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition#March_2018 Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for your contributions!
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(bharatraghunthan9767)
No testing required.
Flags: needinfo?(bharatraghunthan9767) → qe-verify-
Would you please vouch for my profile on mozillians.org (if you think this is a significant contribution)? https://mozillians.org/en-US/u/bharatraghunthan9767/ The notifications from this bug somehow didn't appear in my bugmail earlier, hence the late reply.
Flags: needinfo?(cneiman)
No worries, Bharat! Your profile is vouched. :) Welcome onboard! I look forward to seeing you around the project.
Flags: needinfo?(cneiman)
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: