1441020 - [FTL] Approving pre-0.6 syntax suggestions creates duplicate translations

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P2)

Description

[Théo Chevalier]

Trying to approve a suggestion from someone else in a FTL file, Pontoon duplicates the suggestion and creates a new one attributed to me, and makes it the approved translation.


Example here: https://pontoon.mozilla.org/fr/firefox-screenshots/all-resources/?search=R%C3%A9initialiser&string=174451 The currently approved translation should be Alpha’s suggestion from 3 months ago. Instead, Pontoon duplicated the suggestion and attributed it to me.

Comment 1

[Francesco Lodolo [:flod]]

They're actually different, because the FTL syntax changed a couple of weeks ago.

Your string (note the equal sign after the ID):

annotationClearButton =
    .title = Réinitialiser


Alpha's string

annotationClearButton
    .title = Réinitialiser

You can only see it if you switch to FTL advance mode (i.e. source view)

Comment 2

[Matjaz Horvat [:mathjazz]]

One way around this is to migrate all the existing translations to new syntax. And sync changes to VCS.

Comment 3

[Staś Małolepszy :stas]

How does Pontoon decide to change the author of the suggestion? Does it do a string comparison on the serialized translation? If so, could we change it to compare the AST of the message instead?

Comment 4

[Staś Małolepszy :stas]

BaseNode.equals (https://github.com/projectfluent/python-fluent/blob/0.6.3/fluent/syntax/ast.py#L76) is intended to compare two AST nodes. There's no JS counterpart right now.

Comment 5

[Matjaz Horvat [:mathjazz]]

(In reply to Staś Małolepszy :stas from comment #3)
> How does Pontoon decide to change the author of the suggestion? Does it do a
> string comparison on the serialized translation? If so, could we change it
> to compare the AST of the message instead?

Yes, Pontoon compares Translation.string values, which in case of FTL translations means serialized Messages.

I don't think storing AST as JSON in Translation.string would help here, because the AST also changed in 0.6.

BTW, in the past Pontoon used to store AST as JSON in Translation.string, but we swiched to serialized values after Barcelona, because the syntax was "stable" at that time. :-))

Comment 6

[Staś Małolepszy :stas]

I still think storing the serialized values is the right approach. Comparing two serialized values is best done via parseEntry and BaseNode.equals.

Comment 7

[Matjaz Horvat [:mathjazz]]

You're talking about comparing, not storing - sorry.

Is the plan to continue supporting both, the 0.4 and 0.6 syntax?

Comment 8

[Matjaz Horvat [:mathjazz]]

(In reply to Matjaz Horvat [:mathjazz] from comment #7)
> Is the plan to continue supporting both, the 0.4 and 0.6 syntax?

Stas?

If not, we'll need to do the migration to new syntax at some point anyways.

If yes, I'd still rather do the migration than add complexity to the code.

Comment 9

[Staś Małolepszy :stas]

We'll support Syntax 0.4 in the near future (including the 0.7 releases of fluent-syntax and python-fluent). After that I'd like to plan ending its support. We'll need to make sure we don't have any strings using the old syntax anymore.

(In reply to Matjaz Horvat [:mathjazz] from comment #8)
> If not, we'll need to do the migration to new syntax at some point anyways.
> If yes, I'd still rather do the migration than add complexity to the code.

This x2.

Comment 10

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/893

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/a122b830ef1f64ae6d1a745ebcf169fb5fcd52ed
Fix bug 1441020: Migrate FTL translations to latest syntax (#893)

And also to the latest serializer output. Also: migrate TM entries.