1441048 - Right floated element disappears when using column-count property in ol element.

Status: RESOLVED FIXED

(Core :: Layout: Floats, defect)

Description

[jackson]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36

Steps to reproduce:

Ordered list, with right aligned span in list-item.

jsfiddle: https://jsfiddle.net/Jacksoncds/v4yLzt6k/


Actual results:

The span element disappears for some of the list items.

https://i.stack.imgur.com/OPAlN.png


Expected results:

All span elements should have been displayed.

Comment 1

[Jet Villegas (inactive)]

[Triage 2018/03/23 - P3]

Comment 2

[Karl Dubost💡 :karlcow]

https://webcompat.com/issues/52751 might be another instance of this.
Though that would require a test case.
And chrome and firefox behaves differently here.

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1441048 Part 1 - Clarify variable naming and log when we reflow last column with unconstrained available bsize.

The naming of isMeasuringFeasibleContentBSize and associated log are
misleading. We can change last column's available block-size to be unconstrained
at the end of column balancing [1].

This patch shouldn't change the behavior.

[1] https://searchfox.org/mozilla-central/rev/5c04fc7016eb7f52cf835d482f1125c8f139c959/layout/generic/nsColumnSetFrame.cpp#1144-1154

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1441048 Part 2 - Use NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR to detect block-fragmented context when marking a line dirty.

We can move a float frame into its block parent's PushedFloatsList during column
balancing when it cannot fit in the available block-size.

Later, when the column balancing algorithm reflows the last column in an
unconstrained block-size (in the very last reflow if needed [1]), we have to
reflow the line which contains the float's placeholder. The old code uses
GetPrevInFlow() || GetNextInFlow() to detect this scenario, which is
insufficient because the float's block parent might not have any continuation.
This patch uses NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR bit to detect this instead.

[1] https://searchfox.org/mozilla-central/rev/5c04fc7016eb7f52cf835d482f1125c8f139c959/layout/generic/nsColumnSetFrame.cpp#1144-1154

Depends on D154859

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c41e441c6050
Part 1 - Clarify variable naming and log when we reflow last column with unconstrained available bsize. r=emilio
https://hg.mozilla.org/integration/autoland/rev/30e4adcd2dbd
Part 2 - Use NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR to detect block-fragmented context when marking a line dirty. r=emilio

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35500 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/c41e441c6050
https://hg.mozilla.org/mozilla-central/rev/30e4adcd2dbd