1441054 - Intermittent GECKO(6136) | Assertion failure: mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0 (display list building in the middle of frame construction), at z:/build/build/src/layout/base/nsAutoLayoutPhase.cpp:51

Status: RESOLVED DUPLICATE of bug 1438939

(Core :: Widget: Win32, defect)

Description

[Treeherder Bug Filer]

Filed by: shindli [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=164231931&repo=autoland

https://queue.taskcluster.net/v1/task/OreYKBeDTIa1FCcv-arDXA/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Markus Stange [:mstange]]

nsIconChannel::AsyncOpen2 is called during frame construction, and it can spin the event loop:

nsCSSFrameConstructor::InitAndRestoreFrame -> nsImageBoxFrame::UpdateImage -> nsContentUtils::LoadImage-> imgLoader::LoadImage-> nsIconChannel::AsyncOpen2-> nsIconChannel::AsyncOpen-> nsIconChannel::MakeInputStream-> nsIconChannel::GetHIconFromFile [image/decoders/icon/win/nsIconChannel.cpp:418] -> ::SHGetFileInfo -> ... -> event loop -> Paint

We should avoid spinning the event loop during frame construction.

If the result of nsIconChannel::GetHIconFromFile is needed synchronously, we have a problem. If it's not needed synchronously, we could post a runnable in nsIconChannel::GetHIconFromFile, call ::SHGetFileInfo from that runnable (where we are safely allowed to spin the event loop), and then post the results back to where we need them.