1441124 - nsContentSubTreeIterator is slow

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Cătălin Badea (:catalinb)]

This is a blocker for bug 651120. nsContentSubtreeIterator uses GetChildAt_Deprecated and nsContentUtils::GetAncestorsAndOffsets which causes perf regressions in some cases: spell checking at least.

Comment 1

[Cătălin Badea (:catalinb)]

Attachment: spell.html

Comment 2

[Cătălin Badea (:catalinb)]

Attachment: Refactor nsContentSubtreeIterator: don't use integer indices.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8954055 [details] [diff] [review]
Refactor nsContentSubtreeIterator: don't use integer indices.

No need to do so many changes, and this is rather buggy, unfortunately.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: nsContentSubtreeIterator_no_child_indexing.diff

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/52882db91b661d2ecdb64ece66ef2e236a19a092
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=52882db91b661d2ecdb64ece66ef2e236a19a092
remote: recorded changegroup in replication log in 0.088s


This uses still GetChildAt_Deprecated in assertion to catch issues during try run and possible regressions while removing child array.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

oops, wrong try push
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/2dcc62de6af9dd945572c5a3c293b55513ebdbc2
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=2dcc62de6af9dd945572c5a3c293b55513ebdbc2
remote: recorded changegroup in replication log in 0.105s

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/518b4f3f6b99
nsContentSubtreeIterator should not use GetChildAt_Deprecated, r=ehsan

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/518b4f3f6b99