Closed Bug 1441124 Opened 2 years ago Closed Last year
Content Sub Tree Iterator is slow
This is a blocker for bug 651120. nsContentSubtreeIterator uses GetChildAt_Deprecated and nsContentUtils::GetAncestorsAndOffsets which causes perf regressions in some cases: spell checking at least.
Comment on attachment 8954055 [details] [diff] [review] Refactor nsContentSubtreeIterator: don't use integer indices. No need to do so many changes, and this is rather buggy, unfortunately.
Attachment #8954055 - Attachment is obsolete: true
remote: View your change here: remote: https://hg.mozilla.org/try/rev/52882db91b661d2ecdb64ece66ef2e236a19a092 remote: remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=52882db91b661d2ecdb64ece66ef2e236a19a092 remote: recorded changegroup in replication log in 0.088s This uses still GetChildAt_Deprecated in assertion to catch issues during try run and possible regressions while removing child array.
Assignee: catalin.badea392 → bugs
Attachment #8986186 - Flags: review?(ehsan)
oops, wrong try push remote: View your change here: remote: https://hg.mozilla.org/try/rev/2dcc62de6af9dd945572c5a3c293b55513ebdbc2 remote: remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2dcc62de6af9dd945572c5a3c293b55513ebdbc2 remote: recorded changegroup in replication log in 0.105s
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/518b4f3f6b99 nsContentSubtreeIterator should not use GetChildAt_Deprecated, r=ehsan
You need to log in before you can comment on or make changes to this bug.