Closed Bug 1441192 Opened 3 years ago Closed 3 years ago

Reference cycle caused by PeerConnectionMedia::mQueuedIceCtxOperations

Categories

(Core :: WebRTC: Signaling, enhancement, P2)

59 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: bwc, Assigned: bwc)

References

Details

Attachments

(1 file)

PeerConnectionMedia::mQueuedIceCtxOperations contains runnables which in turn contain a RefPtr back to the PeerConnectionMedia. This could cause the PeerConnectionMedia to be leaked if the operations queue is never cleared. We should probably be clearing that queue in PeerConnectionMedia::SelfDestruct.

This may be what is causing bug 1424398.
Comment on attachment 8954065 [details]
Bug 1441192: Clear ICE operations queue in PeerConnectionMedia::SelfDestruct.

https://reviewboard.mozilla.org/r/223214/#review229442

LGTM
Attachment #8954065 - Flags: review?(drno) → review+
Rank: 15
Priority: -- → P2
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/daf9aa185205
Clear ICE operations queue in PeerConnectionMedia::SelfDestruct. r=drno
https://hg.mozilla.org/mozilla-central/rev/daf9aa185205
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.