Closed
Bug 1441192
Opened 6 years ago
Closed 6 years ago
Reference cycle caused by PeerConnectionMedia::mQueuedIceCtxOperations
Categories
(Core :: WebRTC: Signaling, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
References
Details
Attachments
(1 file)
PeerConnectionMedia::mQueuedIceCtxOperations contains runnables which in turn contain a RefPtr back to the PeerConnectionMedia. This could cause the PeerConnectionMedia to be leaked if the operations queue is never cleared. We should probably be clearing that queue in PeerConnectionMedia::SelfDestruct. This may be what is causing bug 1424398.
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8954065 [details] Bug 1441192: Clear ICE operations queue in PeerConnectionMedia::SelfDestruct. https://reviewboard.mozilla.org/r/223214/#review229442 LGTM
Attachment #8954065 -
Flags: review?(drno) → review+
|
|
||
Updated•6 years ago
|
Rank: 15
Priority: -- → P2
|
Assignee | |
Comment 3•6 years ago
|
||
Retriggers on try seem to indicate that this has cleared up bug 1424398, at least on linux 64 debug. Before: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ee3fdd1fb7beb534833a6677733a8fec44e05ec9&selectedJob=164466757 After: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d118c42f9dad84b3f1213f9f69d6f3e28b3c142&selectedJob=164439050
Blocks: 1424398
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/daf9aa185205 Clear ICE operations queue in PeerConnectionMedia::SelfDestruct. r=drno
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/daf9aa185205
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•