Closed Bug 1441192 Opened 3 years ago Closed 3 years ago
Reference cycle caused by Peer
Connection Media::m Queued Ice Ctx Operations
59 bytes, text/x-review-board-request
PeerConnectionMedia::mQueuedIceCtxOperations contains runnables which in turn contain a RefPtr back to the PeerConnectionMedia. This could cause the PeerConnectionMedia to be leaked if the operations queue is never cleared. We should probably be clearing that queue in PeerConnectionMedia::SelfDestruct. This may be what is causing bug 1424398.
Comment on attachment 8954065 [details] Bug 1441192: Clear ICE operations queue in PeerConnectionMedia::SelfDestruct. https://reviewboard.mozilla.org/r/223214/#review229442 LGTM
Attachment #8954065 - Flags: review?(drno) → review+
Retriggers on try seem to indicate that this has cleared up bug 1424398, at least on linux 64 debug. Before: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ee3fdd1fb7beb534833a6677733a8fec44e05ec9&selectedJob=164466757 After: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d118c42f9dad84b3f1213f9f69d6f3e28b3c142&selectedJob=164439050
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/daf9aa185205 Clear ICE operations queue in PeerConnectionMedia::SelfDestruct. r=drno
You need to log in before you can comment on or make changes to this bug.