1441217 - Use nsXPTMethodInfo instead of XPTMethodDescriptor in XPConnect

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement)

Description

[Andrew McCreight [:mccr8]]

nsXPTMethodInfo is a higher-level version of XPTMethodDescriptor. XPConnect uses the latter for no reason that is clear to me, so this patch switches it to use the former. At the same time, I convert it to use the high-level accessor methods of nsXPTMethodInfo.

We could likely merge these classes, but for bug 1438688 I want to separate them a bit more, where nsXPTMethodInfo becomes a slightly larger structure used on stack to access method info, while XPTMethodDescriptor is a heap structure that requires extra data to use.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1441217 - Use nsXPTMethodInfo instead of XPTMethodDescriptor in XPConnect.

nsXPTMethodInfo is a nicer structure to use, and this paves the way
for making the two types different, which will be needed if I make
XPTMethodDescriptor statically allocated.

Also, use the higher level accessor methods.

Review commit: https://reviewboard.mozilla.org/r/223232/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223232/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8954077 [details]
Bug 1441217 - Use nsXPTMethodInfo instead of XPTMethodDescriptor in XPConnect.

https://reviewboard.mozilla.org/r/223232/#review229406

I like how a lot of the XPCMethodDescriptor parameters were already called `info`.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0921ebb25262
Use nsXPTMethodInfo instead of XPTMethodDescriptor in XPConnect. r=njn

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/0921ebb25262