Move test_caret_*.html files into layout subdirectory

RESOLVED FIXED in Firefox 61

Status

P3
normal
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: whimboo, Assigned: akk5597, Mentored)

Tracking

(Blocks: 1 bug, {good-first-bug})

Version 3
mozilla61
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

(Whiteboard: [lang=py])

User Story

For steps in how to get started please consult our documentation for new users:
https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html

In the case of questions you can find us on IRC in the #ateam channel.

Attachments

(1 attachment)

All the testcase HTML files starting with test_caret_*.html in the following directory seem to be used by layout tests, which basically should not run as part of our unit tests. Given that there is currently no easy way to specify a different location for those tests, all testcase HTML files got added to our base `www` folder:

https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/www/

We should move those files to a subfolder with the name layout, and update the Marionette tests under the following location:

https://dxr.mozilla.org/mozilla-central/source/layout/base/tests/marionette

It could be that some of the files are not needed anymore. If that is the case they have to be removed.
@whimboo, I'd like to work on this. I'm going to first read about what exactly are layout tests and how they differ from unit tests, and then, I'll familiarize with the flow of control among the files involved.

Comment 2

a year ago
Hello Henrik, 
I would like to work on this bug if Pooja is not working on this. If give a chance,this would be first contribution and I am really excited.
Thanks.
Adithya, thank you for your interest. Given that we haven't heard from Pooja for nearly a month feel free to get started on this bug. I will assign it to you once a patch has been uploaded. Thanks.

Comment 4

a year ago
Henrik, thank you so much. I will work on this bug.

Comment 5

a year ago
Hello Henrik, I have a query regarding this bug. Could you please verify if this is the right location to clone from ? 

hg clone http://hg.mozilla.org/mozilla-central/

I did clone from the above location but I am unable to find '/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/www/'. 

Could you please help me out. Looks like I am missing something here. Apologies for troubling you. 

Thanks,
Adithya
Yes, you can clone from that repository, and the files should be present:

https://hg.mozilla.org/mozilla-central/file/tip/testing/marionette/harness/marionette_harness/www

So please check again.
(Assignee)

Comment 7

11 months ago
Hey! Is anyone working on this bug? 
If not, I would like to work on this one.

As I understand, the test_carets_*.html files need to be added in a layout directory and corresponding tests need to point to the correct files.
We haven't heard back from the person in comment 5 for about a month. So yes, please feel free to get started. And yes your assumption is correct.
(Assignee)

Comment 10

11 months ago
Thanks! This is my first attempt at contributing.

So I created the subdirectory and moved the files there and also changed the appropriate lines in the test files.

Then I used

hg bzexport

and the patch has been attached automatically.

How do I ask for a review?
Flags: needinfo?(hskupin)
Attachment #8972032 - Flags: review?(ato)
Attachment #8972032 - Flags: review?(ato) → review+

Comment 12

11 months ago
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a64f46e7fe5
Move test_carets_* files into layout subdirectory. r=ato
Thanks for the patch!  Provided no tests fail, it should land on
central within a few hours.

Aditya: For your reference I’ve updated the author name in your
commit as you had not set one.  I don’t know how to change it in
Mercurial, but if you submit a new patch please make sure you set
the author name to your full name.
(Assignee)

Comment 14

11 months ago
Thanks a lot!
I'm going to follow the mercurial setup guidelines to ensure that I have the required setup.

Comment 15

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1a64f46e7fe5
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee: nobody → akk5597
You need to log in before you can comment on or make changes to this bug.