Closed
Bug 1441496
Opened 7 years ago
Closed 7 years ago
Add words in US English
Categories
(Core :: Spelling checker, enhancement)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: ananuti, Assigned: ananuti)
References
Details
User Story
SpaceX TIF TIFF bupkis https://en.oxforddictionaries.com/definition/us/bupkis crapola https://en.oxforddictionaries.com/definition/us/crapola cybersecurity https://en.oxforddictionaries.com/definition/us/cybersecurity empathic, empathically https://en.oxforddictionaries.com/definition/us/empathic https://en.oxforddictionaries.com/definition/us/empathically exfiltrate, exfiltrated, exfiltrating, exfiltration https://en.oxforddictionaries.com/definition/exfiltrate https://en.oxforddictionaries.com/definition/exfiltration gunsmoke https://www.oxfordlearnersdictionaries.com/us/definition/english/gunsmoke redirections https://en.oxforddictionaries.com/definition/us/redirection revelatory https://en.oxforddictionaries.com/definition/us/revelatory spitballer, spitballing https://en.oxforddictionaries.com/definition/us/spitball https://en.oxforddictionaries.com/definition/spitballer unbox, unboxing, unboxed https://en.oxforddictionaries.com/definition/unbox https://en.oxforddictionaries.com/definition/unboxed https://en.oxforddictionaries.com/definition/unboxing unmaintainable, unmaintained https://en.oxforddictionaries.com/definition/unmaintained https://en.oxforddictionaries.com/definition/unmaintainable viewable https://en.oxforddictionaries.com/definition/viewable whitelist, whitelisted, whitelisting https://en.oxforddictionaries.com/definition/us/whitelist
Attachments
(1 file, 1 obsolete file)
|
4.04 KB,
patch
|
ananuti
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8954340 -
Flags: review?(ehsan)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8954340 [details] [diff] [review]
bug1441496.patch
Review of attachment 8954340 [details] [diff] [review]:
-----------------------------------------------------------------
r=me on everything -SpaceX.
::: extensions/spellcheck/locales/en-US/hunspell/en-US.dic
@@ +11419,5 @@
> Soyinka/M
> Soyuz/M
> Sp
> Spaatz/M
> +SpaceX
I don't think this is a common enough word to warrant being added to the English dictionary. This will likely cause us to suggest "SpaceX" when someone misspells space as spacew for example which isn't great.
Attachment #8954340 -
Flags: review?(ehsan) → review+
|
|
||
Comment 3•7 years ago
|
||
Note that in general the proper way to handle things like SpaceX in our spell checker is to ignore capitalized letters for languages like English which have capitalization rules, not add each noun one by one to our dictionary. :-)
|
|
Assignee | |
Comment 4•7 years ago
|
||
aborted the launch of SpaceX :)
Attachment #8954605 -
Flags: review+
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8954340 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•7 years ago
|
||
[Sheriffs, this patch apply on top of bug 1431550.]
Keywords: checkin-needed
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9642127941a0
Add words to en-US dictionary. r=ehsan
Keywords: checkin-needed
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•