1441635 - Update Debugger Frontend v20

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Comment 1

[Jason Laster [:jlast]]

sanity try run - https://treeherder.mozilla.org/#/jobs?repo=try&revision=c495b258a45e75ab1ac03a6305d4c52982d7f8e3

https://github.com/devtools-html/debugger.html/compare/release-19...release-20

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1da72db1e3a2767c6c078d5fdd5686e59536336

Comment 3

[Jason Laster [:jlast]]

sanity run - https://treeherder.mozilla.org/#/jobs?repo=try&revision=eef69a4bfef2da99c67664466357426aad5b208f
debugger run - https://treeherder.mozilla.org/#/jobs?repo=try&revision=531e96ccb058fbe9899ae9109f55bfb529134adc

Comment 4

[Jason Laster [:jlast]]

a friendly bisect run to help diagnose an issue (if it comes up) https://treeherder.mozilla.org/#/jobs?repo=try&revision=96d1a3df24248275531a325058ff56a9068ea0b7

Comment 5

[Jason Laster [:jlast]]

Attachment: rel-19-2.2.patch

Comment 6

[Jason Laster [:jlast]]

Attachment: rel-19-2.3.patch

Comment 7

[Jason Laster [:jlast]]

Attachment: rel-19-2.4.patch

Comment 8

[Jason Laster [:jlast]]

Attachment: rel-20-1.patch

Comment 9

[Jason Laster [:jlast]]

Initial try runs are great, here's a new one with all the re-runs
https://treeherder.mozilla.org/#/jobs?repo=try&revision=91a08d13a0e5d5b195cf328cdcf6f97288fbfcb8

Comment 10

[Jason Laster [:jlast]]

https://github.com/devtools-html/debugger.html/compare/release-19-2...release-20

Comment 11

[Julian Descottes [:jdescottes]]

Comment on attachment 8958263 [details] [diff] [review]
rel-19-2.4.patch

Review of attachment 8958263 [details] [diff] [review]:
-----------------------------------------------------------------

R+, can we double check the README though?

::: devtools/client/debugger/new/README.mozilla
@@ +1,4 @@
>  This is the debugger.html project output.
>  See https://github.com/devtools-html/debugger.html
>  
>  Version 19.2

So this release contains no commit, but rolls back react, react-dom and webpack?

Comment 12

[Julian Descottes [:jdescottes]]

Comment on attachment 8958265 [details] [diff] [review]
rel-20-1.patch

Review of attachment 8958265 [details] [diff] [review]:
-----------------------------------------------------------------

README update is missing.

Comment 13

[Julian Descottes [:jdescottes]]

- Meta:
 - assigned, P3, enhancement, blocks meta: OK
 - commit message: OK
 - less than 20 commits: ? 
- Try runs
 - try run green: OK
 - try run has rebuild: OK 
- Manual test: OK
- README review
 - compare link: ? 
 - commit link: ?
 - version number: ?
- Properties file review: OK
- New files: No new files

Comment 14

[Julian Descottes [:jdescottes]]

Talos comparison in progress: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=2aef04d16f6be8b167ac6b67cf5b975a2664f654&newProject=try&newRevision=bc27f15b586c11f58dbefa24d05c9f306f48e8c8&framework=1 

(might take a while)

Comment 15

[Jason Laster [:jlast]]

Attachment: rel-20-2.patch

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb3619ae3425
Re-align webpack module ordering. r=jdescottes
https://hg.mozilla.org/integration/mozilla-inbound/rev/907c98c2f3c8
Update Debugger Frontend v20. r=jdescottes

Comment 17

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/eb3619ae3425
https://hg.mozilla.org/mozilla-central/rev/907c98c2f3c8

Comment 18

[Julian Descottes [:jdescottes]]

Talos results: 
- 2% slowdown on complicated.jsdebugger.open

https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=2aef04d16f6be8b167ac6b67cf5b975a2664f654&newProject=try&newRevision=bc27f15b586c11f58dbefa24d05c9f306f48e8c8&originalSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&newSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&showOnlyConfident=1&framework=1