1441688 - Remove nsIIPCSerializableURI.Deserialize

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

In order to make URI implementations immutable, nsIIPCSerializableURI.Deserialize needs to be removed.
Deserialization already happens using mutators (see URIUtils.cpp::DeserializeURI)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1441688 - Remove nsIIPCSerializableURI.Deserialize

Review commit: https://reviewboard.mozilla.org/r/223612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223612/

Comment 2

[Honza Bambas (:mayhemer)]

OK, so the only way to deserialize a URI is via [1], which forwards now to the (private) Deserialize() impl on respective uri classes, right?



[1] https://searchfox.org/mozilla-central/rev/14d933246211b02f5be21d2e730a57cf087c6606/netwerk/base/nsIURIMutator.idl#57-66

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8954560 [details]
Bug 1441688 - Remove nsIIPCSerializableURI.Deserialize

https://reviewboard.mozilla.org/r/223612/#review229870

Comment 4

[Valentin Gosu [:valentin] (he/him)]

(In reply to Honza Bambas (:mayhemer) from comment #2)
> OK, so the only way to deserialize a URI is via [1], which forwards now to
> the (private) Deserialize() impl on respective uri classes, right?

Yes, exactly.

Comment 5

[Valentin Gosu [:valentin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=478c2179340f97687b4f8d385fddf19c4dac8f89

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8954560 [details]
Bug 1441688 - Remove nsIIPCSerializableURI.Deserialize

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223612/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e7b27d3a00f
Remove nsIIPCSerializableURI.Deserialize r=mayhemer

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/1e7b27d3a00f