Closed Bug 1441688 Opened 2 years ago Closed 2 years ago

Remove nsIIPCSerializableURI.Deserialize

Categories

(Core :: Networking, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: valentin, Assigned: valentin)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

In order to make URI implementations immutable, nsIIPCSerializableURI.Deserialize needs to be removed.
Deserialization already happens using mutators (see URIUtils.cpp::DeserializeURI)
Priority: -- → P1
Priority: P1 → P2
OK, so the only way to deserialize a URI is via [1], which forwards now to the (private) Deserialize() impl on respective uri classes, right?



[1] https://searchfox.org/mozilla-central/rev/14d933246211b02f5be21d2e730a57cf087c6606/netwerk/base/nsIURIMutator.idl#57-66
Comment on attachment 8954560 [details]
Bug 1441688 - Remove nsIIPCSerializableURI.Deserialize

https://reviewboard.mozilla.org/r/223612/#review229870
Attachment #8954560 - Flags: review?(honzab.moz) → review+
(In reply to Honza Bambas (:mayhemer) from comment #2)
> OK, so the only way to deserialize a URI is via [1], which forwards now to
> the (private) Deserialize() impl on respective uri classes, right?

Yes, exactly.
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1e7b27d3a00f
Remove nsIIPCSerializableURI.Deserialize r=mayhemer
https://hg.mozilla.org/mozilla-central/rev/1e7b27d3a00f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.