1441713 - Skip SynchronizeForSnapshot in the case of reftest-no-flush too

Status: RESOLVED FIXED

(Testing :: Reftest, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

That's because nsDOMWindowUtils.updateLayerTree() flushes styles (actually it specifies FlushType::Display though).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fffce59b3734d1206bd0663e61ea943672e735a

In the above try, I did skip whole step of SynchronizeForSnapshot, but should we skip only updateLayerTree() instead?  I think if we want to test async scrolling and async animation simultaneously we will specify both reftest-no-sync-layers and reftest-no-flush, so it will not be matter, but I defer to dbaron's opinion.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1441713 - Skip SynchronizeForSnapshot in the case of 'reftest-no-flush'.

Since updateLayerTree flushes styles.

Review commit: https://reviewboard.mozilla.org/r/223668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223668/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

I had been wondering why some reftests which specify reftest-no-flush take the snapshot after animation finished on WebRender.  That's because nsDOMWindowUtils.updateLayerTree() in question is called from the callback of MozAfterPaint event, thus we do flush throttled animations again, then wait for MozAfterPaint event, then repeat this cycle until the animation end.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8954579 [details]
Bug 1441713 - Skip SynchronizeForSnapshot in the case of 'reftest-no-flush'.

https://reviewboard.mozilla.org/r/223668/#review230098

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Thanks for the review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44363ede4383
Skip SynchronizeForSnapshot in the case of 'reftest-no-flush'. r=dbaron

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/44363ede4383