Closed Bug 1441753 Opened 3 years ago Closed 3 years ago

2d Canvas sample is not updated when tab is moved to different window

Categories

(Core :: Graphics: WebRender, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

With the following STR, canvas 2d sample was not updated when tab is moved to different window.

[1] Open multiple tabs on window
[2] Open http://corehtml5canvas.com/code-live/ch01/example-1.8/example.html in a tab.
[3] Push "Start", then bouncing balls animation starts.
[4] Move the tab to different window.

At [4], the page stop to update the bouncing balls. It did not happen when WebRender was disabled.
Assignee: nobody → sotaro.ikeda.g
I saw the problem only on Linux. I did not saw the problem on win and on mac.
about:support had the following failure log when the problem happened.

> 	CP+[GFX1]: Unexpected BufferProvider over-production.
When PersistentBufferProviderShared::BorrowDrawTarget() returned nullptr, CanvasRenderingContext2D created PersistentBufferProviderBasic and used it as fallback. But CanvasRenderingContext2D continued to use old CanvasRenderer which held old PersistentBufferProviderShared. Since CopyableCanvasRenderer::IsDataValid() returned true.

CopyableCanvasRenderer::IsDataValid() should return false when BufferProvider is different.
attachment 8956393 [details] [diff] [review] addressed the problem for me.
Attachment #8956393 - Flags: review?(nical.bugzilla)
Comment on attachment 8956393 [details] [diff] [review]
patch - Fix CopyableCanvasRenderer::IsDataValid()

Review of attachment 8956393 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!
Attachment #8956393 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fae6107e46e8
Fix CopyableCanvasRenderer::IsDataValid() r=nical
https://hg.mozilla.org/mozilla-central/rev/fae6107e46e8
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.