1441753 - 2d Canvas sample is not updated when tab is moved to different window

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Sotaro Ikeda [:sotaro]]

With the following STR, canvas 2d sample was not updated when tab is moved to different window.

[1] Open multiple tabs on window
[2] Open http://corehtml5canvas.com/code-live/ch01/example-1.8/example.html in a tab.
[3] Push "Start", then bouncing balls animation starts.
[4] Move the tab to different window.

At [4], the page stop to update the bouncing balls. It did not happen when WebRender was disabled.

Comment 1

[Sotaro Ikeda [:sotaro]]

I saw the problem only on Linux. I did not saw the problem on win and on mac.

Comment 2

[Sotaro Ikeda [:sotaro]]

about:support had the following failure log when the problem happened.

> 	CP+[GFX1]: Unexpected BufferProvider over-production.

Comment 3

[Sotaro Ikeda [:sotaro]]

When PersistentBufferProviderShared::BorrowDrawTarget() returned nullptr, CanvasRenderingContext2D created PersistentBufferProviderBasic and used it as fallback. But CanvasRenderingContext2D continued to use old CanvasRenderer which held old PersistentBufferProviderShared. Since CopyableCanvasRenderer::IsDataValid() returned true.

CopyableCanvasRenderer::IsDataValid() should return false when BufferProvider is different.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix CopyableCanvasRenderer::IsDataValid()

Comment 5

[Sotaro Ikeda [:sotaro]]

attachment 8956393 [details] [diff] [review] addressed the problem for me.

Comment 6

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d29ae9b9fb75ffe7b3e014e1551336f96968afca

Comment 7

[Nicolas Silva [:nical]]

Comment on attachment 8956393 [details] [diff] [review]
patch - Fix CopyableCanvasRenderer::IsDataValid()

Review of attachment 8956393 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fae6107e46e8
Fix CopyableCanvasRenderer::IsDataValid() r=nical

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fae6107e46e8