Closed
Bug 1441753
Opened 7 years ago
Closed 7 years ago
2d Canvas sample is not updated when tab is moved to different window
Categories
(Core :: Graphics: WebRender, defect, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file)
597 bytes,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
With the following STR, canvas 2d sample was not updated when tab is moved to different window.
[1] Open multiple tabs on window
[2] Open http://corehtml5canvas.com/code-live/ch01/example-1.8/example.html in a tab.
[3] Push "Start", then bouncing balls animation starts.
[4] Move the tab to different window.
At [4], the page stop to update the bouncing balls. It did not happen when WebRender was disabled.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•7 years ago
|
||
I saw the problem only on Linux. I did not saw the problem on win and on mac.
Assignee | ||
Comment 2•7 years ago
|
||
about:support had the following failure log when the problem happened.
> CP+[GFX1]: Unexpected BufferProvider over-production.
Updated•7 years ago
|
Blocks: stage-wr-nightly
Priority: -- → P1
Assignee | ||
Comment 3•7 years ago
|
||
When PersistentBufferProviderShared::BorrowDrawTarget() returned nullptr, CanvasRenderingContext2D created PersistentBufferProviderBasic and used it as fallback. But CanvasRenderingContext2D continued to use old CanvasRenderer which held old PersistentBufferProviderShared. Since CopyableCanvasRenderer::IsDataValid() returned true.
CopyableCanvasRenderer::IsDataValid() should return false when BufferProvider is different.
Assignee | ||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 5•7 years ago
|
||
attachment 8956393 [details] [diff] [review] addressed the problem for me.
Assignee | ||
Comment 6•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8956393 -
Flags: review?(nical.bugzilla)
Comment 7•7 years ago
|
||
Comment on attachment 8956393 [details] [diff] [review]
patch - Fix CopyableCanvasRenderer::IsDataValid()
Review of attachment 8956393 [details] [diff] [review]:
-----------------------------------------------------------------
Nice catch!
Attachment #8956393 -
Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fae6107e46e8
Fix CopyableCanvasRenderer::IsDataValid() r=nical
Comment 9•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•