1441788 - Expose Reader View shortcut in the address bar button's tooltip

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement)

Description

[Dão Gottwald [:dao]]

We're by now pretty good at exposing keyboard shortcuts in tooltips, but it seems this one was missed so far. Alas fixing this means removing the "Enter Reader View" / "Close Reader View" distinction.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1441788 - Expose Reader View shortcut in the address bar button's tooltip.

Review commit: https://reviewboard.mozilla.org/r/223798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223798/

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8954688 [details]
Bug 1441788 - Expose Reader View shortcut in the address bar button's tooltip.

https://reviewboard.mozilla.org/r/223798/#review229834

Gosh, when I invoked the Reader Mode keycode it restarted Nightly, which is apparently a development feature of some sort. Scared me a sec there!

This is nice a11y change. Ship it!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ed5cde4cb2c
Expose Reader View shortcut in the address bar button's tooltip. r=mikedeboer

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5ed5cde4cb2c

Comment 5

[Mohammad Maruf Rahman]

I have reproduced this bug with 61.0a1 (2018-02-28) on Ubuntu 16.04 LTS!

This bug's fix is Verified with latest Beta!

Build   ID    20180322152034
User Agent    Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Comment 6

[Sajedul Islam]

I have reproduced this bug with 60.0a1 (2018-02-28) on Windows 10 (64-bit)!

This bug's fix is Verified with latest Beta!

Build   ID    20180322152034
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0

[testday-20180323]

Comment 7

[Mohammad Maruf Rahman]

As per comment 5 and comment 6, I am marking this bug as Verified Fixed!