Closed Bug 1441791 Opened 2 years ago Closed 2 years ago

Use MOZILLA_DIR when including AB_rCD.mk

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla60

People

(Reporter: jorgk, Assigned: Fallen)

Details

Attachments

(2 files)

My local build is currently busted:

 0:18.11 c:/mozilla-source/comm-central/mozilla/config/config.mk:342: c:/mozilla-source/comm-central/config/AB_rCD.mk: No such file or directory
 0:18.11 mozmake.EXE[4]: *** No rule to make target 'c:/mozilla-source/comm-central/config/AB_rCD.mk'.  Stop.
 0:18.55 c:/mozilla-source/comm-central/mozilla/config/recurse.mk:100: recipe for target 'mailnews/mapi/mapiDLL/export' failed
 0:18.55 mozmake.EXE[3]: *** [mailnews/mapi/mapiDLL/export] Error 2
 0:18.55 mozmake.EXE[3]: *** Waiting for unfinished jobs....
 0:18.56 c:/mozilla-source/comm-central/mozilla/config/config.mk:342: c:/mozilla-source/comm-central/config/AB_rCD.mk: No such file or directory
 0:18.56 mozmake.EXE[4]: *** No rule to make target 'c:/mozilla-source/comm-central/config/AB_rCD.mk'.  Stop.
 0:18.56 c:/mozilla-source/comm-central/mozilla/config/recurse.mk:100: recipe for target 'mailnews/mapi/mapihook/build/export' failed
 0:18.56 mozmake.EXE[3]: *** [mailnews/mapi/mapihook/build/export] Error 2

Copying AB_rCD.mk from M-C to C-C's config/ appears to fix the problem, at least the build goes past the initial error. Maybe it will fail later.
Flags: needinfo?(philipp)
Flags: needinfo?(mozilla)
Keywords: leave-open
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b4ceffca370c
Port bug 1439742: add config/AB_rCD.mk. rs=bustage-fix CLOSED TREE
Attached patch m-c fix - v1Splinter Review
This should go away if m-c's config.mk uses MOZILLA_DIR to reference the correct path, similar to the other includes in that file.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Flags: needinfo?(philipp)
Attachment #8954710 - Flags: review?(ted)
Flags: needinfo?(mozilla)
Thanks Philipp. The bustage fix can be backed out, but it's good to have a build since new (test) bustage has already arrived :-( - Makes bisecting this easier.
Attachment #8954710 - Flags: review?(ted) → review+
Keywords: leave-open
Product: Thunderbird → Core
Summary: Port |Bug 1439742 - Use LOCALIZED_{GENERATED_}FILES in mobile/android| - comm-central/config/AB_rCD.mk: No such file or directory → Use MOZILLA_DIR when including AB_rCD.mk
Attachment #8954701 - Attachment description: 1441791-AB_rCD.mk.patch → comm-central temporary fix - v1
Pushed by mozilla@kewis.ch:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c68b03e4324f
Use MOZILLA_DIR when including from mozilla topsrcdir. r=ted
https://hg.mozilla.org/mozilla-central/rev/c68b03e4324f
Use MOZILLA_DIR when including from mozilla topsrcdir. r=ted
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/6c63128a12ca
Backed out changeset b4ceffca370c for being a temporary fix. a=jorgk
Attachment #8954701 - Attachment description: comm-central temporary fix - v1 → comm-central temporary fix - v1 [backed out in comment #7]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.