Closed Bug 1441794 Opened 4 years ago Closed 4 years ago

Add deprecation warning to OBJECT_SUBREQUEST for stable releases

Categories

(Core :: DOM: Security, enhancement, P1)

60 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: jkt, Assigned: jkt)

References

(Blocks 1 open bug)

Details

(Keywords: site-compat)

Attachments

(1 file)

Due to more breakage reports than we would like we are going to implement more telemetry to allow us to measure the deprecation of treating requests over insecure connections embedded within flash plugins.

This will allow us to measure more than before and also clearly state to release users/developers that we plan to remove this.
Comment on attachment 8954728 [details]
Bug 1441794 - Add deprecation warning to passive OBJECT_SUBREQUEST loads.

https://reviewboard.mozilla.org/r/223862/#review229968

I think that looks fine. r=me

::: dom/locales/en-US/chrome/dom/dom.properties:357
(Diff revision 1)
>  InvalidKeyframePropertyValue=Keyframe property value “%1$S” is invalid according to the syntax for “%2$S”.
>  # LOCALIZATION NOTE: Do not translate "ReadableStream".
>  ReadableStreamReadingFailed=Failed to read data from the ReadableStream: “%S”.
>  # LOCALIZATION NOTE: Do not translate "registerProtocolHandler".
>  RegisterProtocolHandlerInsecureWarning=Use of the registerProtocolHandler for insecure connections will be removed in version 62.
> +MixedDisplayObjectSubrequestWarning=Loading insecure content within a plugin embedded on a secure connection is going to be removed.

I am not sure and don't have a strong opinion, maybe:

Loading insecure content within a plugin embedded within a page loaded over a secure connection is going to be removed.
Attachment #8954728 - Flags: review?(ckerschb) → review+
Comment on attachment 8954728 [details]
Bug 1441794 - Add deprecation warning to passive OBJECT_SUBREQUEST loads.

https://reviewboard.mozilla.org/r/223862/#review229968

> I am not sure and don't have a strong opinion, maybe:
> 
> Loading insecure content within a plugin embedded within a page loaded over a secure connection is going to be removed.

We agreed on "in" on irc to remove repetition of within.
Pushed by jkingston@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28e43d931982
Add deprecation warning to passive OBJECT_SUBREQUEST loads. r=ckerschb
https://hg.mozilla.org/mozilla-central/rev/28e43d931982
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.