Closed Bug 1441816 Opened 4 years ago Closed 4 years ago

Move mTabProgressListener into its own class

Categories

(Firefox :: Tabbed Browser, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

This code is already self-contained and the extra indentation due to this object being embedded in the TabBrowser class is just annoying. This should also save some resources, since currently every object returned by mTabProgressListener is a brand-new one that doesn't share anything with the other "instances."
Reviewboard is trying to be too smart, completely messing up the diff view. Please view the plain diff instead:

https://hg.mozilla.org/try/rev/b6c49013ef30da68bb6c1fbc9f91b5e0f21fb4d7

Here's basically what I did:

1. replace this.mTabBrowser with gBrowser
2. replace this.mTabProgressListener with new TabProgressListener
3. move the code
4. fix up indentation
Attachment #8954729 - Flags: review?(jaws)
Comment on attachment 8954729 [details]
Bug 1441816 - Move mTabProgressListener into its own class.

https://reviewboard.mozilla.org/r/223866/#review230016

Thank you for linking to the diff on tryserver. I admit I had looked at the reviewboard diff and de-prioritized the review due to how crazy it looked on reviewboard.
Attachment #8954729 - Flags: review?(jaws) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s fc5a5ffed43bec87b239139d7249e514a4d9b5e7 -d e03272cbedc0: rebasing 449533:fc5a5ffed43b "Bug 1441816 - Move mTabProgressListener into its own class. r=jaws" (tip)
merging browser/base/content/tabbrowser.js
warning: conflicts while merging browser/base/content/tabbrowser.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c884294ea2dd
Move mTabProgressListener into its own class. r=jaws
https://hg.mozilla.org/mozilla-central/rev/c884294ea2dd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Depends on: 1442398
You need to log in before you can comment on or make changes to this bug.