Open
Bug 1441831
Opened 7 years ago
Updated 3 years ago
Potential memory leak in mozilla-unified/media/mtransport/nr_timer.cpp:216
Categories
(Core :: WebRTC: Networking, defect, P3)
Core
WebRTC: Networking
Tracking
()
NEW
People
(Reporter: fan.gang.cn, Unassigned)
Details
Attachments
(1 file)
140.14 KB,
image/png
|
Details |
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36
Steps to reproduce:
Scan Code with SourceBrella Pinpoint
Actual results:
File mozilla-unified/media/mtransport/nr_timer.cpp:216
The allocated variable callback on line 210 is leaked when the program returns on line 217.
I've uploaded a screenshot with source code and comments for a better description.
Comment 1•7 years ago
|
||
Based on the source code location, I believe this should belong to the core/WebRTC.
Component: Untriaged → WebRTC
Product: Firefox → Core
Comment 2•7 years ago
|
||
Looks legit. Thanks for filing!
Nils, who maintains mtransport these days?
Status: UNCONFIRMED → NEW
Rank: 25
Component: WebRTC → WebRTC: Networking
Ever confirmed: true
Flags: needinfo?(drno)
Priority: -- → P3
Comment 3•7 years ago
|
||
Looks like we can't delete it directly. And callback->Cancel() assumes that _timer has been set before. I guess we need to modify nrappkitTimerCallback one way or the other.
Byron, any thoughts on this?
Flags: needinfo?(drno) → needinfo?(docfaraday)
Comment 4•7 years ago
|
||
(In reply to Nils Ohlmeier [:drno] from comment #3)
> Looks like we can't delete it directly. And callback->Cancel() assumes that
> _timer has been set before. I guess we need to modify nrappkitTimerCallback
> one way or the other.
>
> Byron, any thoughts on this?
I would think we could put it in a RefPtr when we create it.
Flags: needinfo?(docfaraday)
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•