1441831 - Potential memory leak in mozilla-unified/media/mtransport/nr_timer.cpp:216

Status: NEW

(Core :: WebRTC: Networking, defect, P3)

Description

[fan.gang.cn]

Attachment: Screenshot from 2018-02-28 22:24:43.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Steps to reproduce:

Scan Code with SourceBrella Pinpoint


Actual results:

File mozilla-unified/media/mtransport/nr_timer.cpp:216

The allocated variable callback on line 210 is leaked when the program returns on line 217. 

I've uploaded a screenshot with source code and comments for a better description.

Comment 1

[Adrian Florinescu [:aflorinescu]]

Based on the source code location, I believe this should belong to the core/WebRTC.

Comment 2

[Andreas Pehrson [:pehrsons] (PTO; back in Aug)]

Looks legit. Thanks for filing!

Nils, who maintains mtransport these days?

Comment 3

[Nils Ohlmeier [:drno]]

Looks like we can't delete it directly. And callback->Cancel() assumes that _timer has been set before. I guess we need to modify nrappkitTimerCallback one way or the other.

Byron, any thoughts on this?

Comment 4

[Byron Campen [:bwc]]

(In reply to Nils Ohlmeier [:drno] from comment #3)
> Looks like we can't delete it directly. And callback->Cancel() assumes that
> _timer has been set before. I guess we need to modify nrappkitTimerCallback
> one way or the other.
> 
> Byron, any thoughts on this?

I would think we could put it in a RefPtr when we create it.