1441842 - Potential memory leak in media/libvpx/libvpx/vp8/vp8_cx_iface.c:594

Status: NEW

(Core :: Audio/Video: Recording, defect, P3)

Description

[fan.gang.cn]

Attachment: Screenshot from 2018-02-28 22:40:55.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Steps to reproduce:

Scan Code with SourceBrella Pinpoint


Actual results:

File: media/libvpx/libvpx/vp8/vp8_cx_iface.c:594

The memory shared_mem_loc allocated on line 587 is leaked when the program takes the true branch on line 594. It is a rare case, but better fix it. 

I've uploaded a screenshot with source code and comments for a better description.

Comment 1

[Adrian Florinescu [:aflorinescu]]

Based on the source code location, I believe this could start in Core::A/V in order to be further triaged.

Comment 2

[Alex Chronopoulos [:achronop]]

This is in upstream code I am not sure how easy it is to request a change.

Comment 3

[Andreas Pehrson [:pehrsons]]

You should file this upstream really, https://www.webmproject.org/code/bug-reporting/

That said, when this leaks we're likely to OOM soon anyway, and that will take the process down. This is then pretty low prio.

Comment 4

[fan.gang.cn]

(In reply to Andreas Pehrson [:pehrsons] from comment #3)
> You should file this upstream really,
> https://www.webmproject.org/code/bug-reporting/
> 
> That said, when this leaks we're likely to OOM soon anyway, and that will
> take the process down. This is then pretty low prio.

OK, thanks.