Closed Bug 1441877 Opened 4 years ago Closed 4 years ago

--breakpoint-hover-background is defined but never referenced

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: jaws, Assigned: jdescottes)

References

Details

Attachments

(1 file)

It looks like bug 1331654 updated the debugger front-end, moving some styles to old-debugger.css. The property of --breakpoint-hover-background is never used.

It's been 1 year since the debugger was updated. Can this file be deleted now?
Flags: needinfo?(jdescottes)
This file is used by DevTools' sourceeditor (used by the new debugger, the old debugger, styleeditor etc...).
The old debugger can not be removed yet, that's https://bugzilla.mozilla.org/show_bug.cgi?id=1314057.

> Can this file be deleted now?

The file is still needed for the old debugger breakpoints. We can remove the variable you mentioned though.
Flags: needinfo?(jdescottes)
Comment on attachment 8954800 [details]
Bug 1441877 - remove unused css variable --breakpoint-hover-background;

https://reviewboard.mozilla.org/r/223926/#review229936
Attachment #8954800 - Flags: review?(jaws) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6264884db15
remove unused css variable --breakpoint-hover-background;r=jaws
https://hg.mozilla.org/mozilla-central/rev/f6264884db15
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Assignee: nobody → jdescottes
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.