1441877 - --breakpoint-hover-background is defined but never referenced

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

It looks like bug 1331654 updated the debugger front-end, moving some styles to old-debugger.css. The property of --breakpoint-hover-background is never used.

It's been 1 year since the debugger was updated. Can this file be deleted now?

Comment 1

[Julian Descottes [:jdescottes]]

This file is used by DevTools' sourceeditor (used by the new debugger, the old debugger, styleeditor etc...).
The old debugger can not be removed yet, that's https://bugzilla.mozilla.org/show_bug.cgi?id=1314057.

> Can this file be deleted now?

The file is still needed for the old debugger breakpoints. We can remove the variable you mentioned though.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1441877 - remove unused css variable --breakpoint-hover-background;

Review commit: https://reviewboard.mozilla.org/r/223926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223926/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8954800 [details]
Bug 1441877 - remove unused css variable --breakpoint-hover-background;

https://reviewboard.mozilla.org/r/223926/#review229936

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6264884db15
remove unused css variable --breakpoint-hover-background;r=jaws

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/f6264884db15