Closed
Bug 1441912
Opened 7 years ago
Closed 7 years ago
Replace thUrl angular provider with urlHelper lib
Categories
(Tree Management :: Treeherder: Frontend, enhancement)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: camd, Assigned: camd)
References
Details
Attachments
(1 file)
This lets the functions work with both react and angular.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → cdawson
|
|
Assignee | |
Updated•7 years ago
|
Blocks: treeherder-react
|
||
Comment 1•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8954993 -
Flags: review?(emorley)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8954993 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3285
Oops, missed a couple test failures...
Attachment #8954993 -
Flags: review?(emorley)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Comment on attachment 8954993 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3285
This has been rebased now. Hopefully tests pass after the push. :)
Attachment #8954993 -
Flags: review?(emorley)
|
||
Updated•7 years ago
|
Attachment #8954993 -
Flags: review?(emorley) → review+
|
||
Comment 4•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/2240fbd3a9bf33657ed6d070a00c6441fcbc2551
Bug 1441912 - Replace thUrl angular provider with urlHelper lib (#3285)
* Move getBugUrl, getSlaveHealthUrl, getInspectTaskUrl, getWorkerExplorerUrl,
getLogViewerUrl, getRootUrl, getProjectUrl and getProjectJobUrl to urlHelper
* Move getJobsUrl to only place its used
* Replace thServiceDomain with SERVICE_DOMAIN
* remove thUrl provider
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•