Closed Bug 1441971 Opened 5 years ago Closed 5 years ago

Aborting XULDocument load can lead to aborted script loads for waiting docs

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

When two XULDocuments are loaded in quick succession, and both of them depend on the same script file, the second doc can wait on the first doc to load the script [1].

However, if the first doc load is aborted, the corresponding script load will be aborted as well. In this case, because the second doc depends on the same script, the script load for the second doc is aborted as well.

The second doc will therefore end up with a script load error, even though the second doc has nothing to do with the first doc, other than just happening to load the same script as the first doc at the same time.

[1] https://searchfox.org/mozilla-central/rev/14d933246211b02f5be21d2e730a57cf087c6606/dom/xul/XULDocument.cpp#2935
Attachment #8954888 - Flags: review?(jvarga) → review?(bzbarsky)
Comment on attachment 8954888 [details]
Bug 1441971 - Restart aborted script load for waiting XULDocument loads;

https://reviewboard.mozilla.org/r/224046/#review238668

Ideally we wouldn't do these loads in a document loadgroup, if they span across documents...
Attachment #8954888 - Flags: review?(bzbarsky) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3b12adc84b1
Restart aborted script load for waiting XULDocument loads; r=bz
https://hg.mozilla.org/mozilla-central/rev/c3b12adc84b1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.