1441974 - 3 Pane toggle fires twice

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. Set the following prefs:

devtools.inspector.split-sidebar-toggle: true
devtools.inspector.split-rule-enabled: false

2. Try to use the 3 Pane toggle to enable 3 Pane mode

ER:

Rules moves to a new pane.

AR:

3 rules panels appear in the existing sidebar pane.

Cause:

Bug 1420130 removed the React monkeypatch, which seems to have led to some event being fired twice.  In this case, the sidebar toggle gets 2 click events, so it toggle off and on very fast.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1441974 - Avoid duplicate clicks in sidebar toggle.

After the React monkeypatch removal (bug 1420130), some events can be duplicated
because both privileged and non-privileged versions are dispatched.

To work around this, we can stop propagation for the event in cases like this
where it is safe to do so.

Review commit: https://reviewboard.mozilla.org/r/224050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224050/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8954890 [details]
Bug 1441974 - Avoid duplicate clicks in sidebar toggle.

https://reviewboard.mozilla.org/r/224050/#review230058

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/853caeaad89b
Avoid duplicate clicks in sidebar toggle. r=gl

Comment 4

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/853caeaad89b