1442003 - Lando API should return all dates as iso 8601 with timezones

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement)

Description

[Steven MacLeod [:smacleod]]

Some of the dates lando API is returning are in iso 8601, but missing the timezone component. While these dates are UTC as intended, the spec states that timestamps without the timezone should be considered local time. We should make sure all the returned timestamps have the timezone (UTC).

Examples:
 - \landings:
   - 'created_at': '2018-02-09T20:48:20.293139'
   - 'updated_at': '2018-02-09T20:48:22.086858'

Comment 1

[Israel Madueme [:imadueme]]

I think this bug is important enough to do now because it is actually causing the UI to lie to the user as per the screenshot I've attached. The diff time is correct because it properly has the UTC timezone set by lando-api (fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1441607).

Comment 2

[Israel Madueme [:imadueme]]

Attachment: time-offset-bad.PNG

Comment 3

[Israel Madueme [:imadueme]]

What do you think?

Comment 4

[Mark Côté [:mcote]]

I think this can be filed (and communicated) as a known bug, since it's straightforward enough (mis)behaviour.

Comment 5

[Phabricator Automation]

Attachment: landings: fix Landing dates.

Comment 6

[Phabricator Automation]

Comment on attachment 8960336 [details]
landings: fix Landing dates.

Byron Jones ‹:glob› has approved the revision.

https://phabricator.services.mozilla.com/D774