1442037 - Intermittent image/test/mochitest/test_discardFramesAnimatedImage.html | application crashed [@ mozilla::image::DecoderFactory::CloneAnimationDecoder]

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=164940715&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/GF5z_Q-fRB2fkdKdPFiqtg/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

> [task 2018-02-28T20:00:21.607Z] 20:00:21     INFO -  02-28 12:00:04.660 F/MOZ_Assert(  804): Assertion failure: aDecoder->HasAnimation(), at /builds/worker/workspace/build/src/image/DecoderFactory.cpp:232

I've convinced myself it is the assert that is the problem, rather than being indicative of a problem.

Possible sequence of events:
1) Metadata decode determines it is an animated image.
2) We create an AnimationSurfaceProvider and decode enough frames to go over the discard threshold.

3a) We reset the animation, and clone a new decoder. A task is waiting in the decoding task queue.
  OR
3b) Decoding finishes and we clone new decoder. We don't need any more frames at this moment, so we stop decoding and wait for the animation to progress to redecode.

4) Before the decoder gets a chance to run, we reset the animation again. The decoder hasn't produced any metadata and we trip the assert.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: 0001-Bug-1442037-Fix-an-incorrect-assert-in-DecoderFactor.patch, v1

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad585b69ae77b4ff6f6322ce66c0cd2cf49763a0

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a5462439ead
Fix an incorrect assert in DecoderFactory::CloneAnimationDecoder. r=tnikkel

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3a5462439ead

Comment 5

[Intermittent Failures Robot]

3 failures in 831 pushes (0.004 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 2
* mozilla-central: 1

Platform breakdown:
* android-4-3-armv7-api16: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1442037&startday=2018-02-26&endday=2018-03-04&tree=all