Closed Bug 1442127 Opened 7 years ago Closed 7 years ago

Fix ESR Test Breaks from Timer Rounding

Categories

(Firefox :: General, enhancement)

Product:
Firefox
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr52 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

Attachments

(2 files)

Bug 1442127 Allow function call times to occur at the same time in browser_profiling-canvas.js for ESR branch
59 bytes, text/x-review-board-request
baku
: review+
Details
Bug 1442127 Allow timestamps to be equal in video delay
59 bytes, text/x-review-board-request
baku
: review+
Details
Attachment #8955021 - Flags: review?(amarchesini)
Attachment #8955022 - Flags: review?(amarchesini)
Comment on attachment 8955021 [details] Bug 1442127 Allow function call times to occur at the same time in browser_profiling-canvas.js for ESR branch https://reviewboard.mozilla.org/r/224196/#review230168
Attachment #8955021 - Flags: review?(amarchesini) → review+
Comment on attachment 8955022 [details] Bug 1442127 Allow timestamps to be equal in video delay https://reviewboard.mozilla.org/r/224198/#review230170
Attachment #8955022 - Flags: review?(amarchesini) → review+
Treeherder shows lots of failures, but those tests aren't there. I'm not sure if any other ones need to be addressed also; I spot checked some of the WPT, but they aren't using timing information at all...
Flags: needinfo?(ryanvm)
The Try push is inconclusive because the failures were only happening on opt builds and it only tested debug.
Flags: needinfo?(ryanvm)
Looks great, thanks.
Whiteboard: [checkin-needed-esr52]
Should this bug be closed mow?
Flags: needinfo?(tom)
Yup, thanks!
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(tom)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: