1442155 - Add-on name is not displayed in Install prompt on Android

Status: VERIFIED FIXED

(WebExtensions :: Android, defect, P1)

Description

[Alexandra Moga [:LexaSV]]

Attachment: install_prompt.png

[Affected versions]:
- Firefox 60.0a1

[Affected platforms]:
- Android 7.0
- Android 8.0.0
 

[Steps to reproduce]:
1. Access AMO homepage on your Android device
2.Go to an add-on details page and install it (i.e. https://addons.mozilla.org/en-US/android/addon/ghostery/)
3.Check the information displayed on the install prompt


[Expected results]:
- The add-on name is correctly displayed

[Actual results]:
- Add-on name is displayed as "<>"

Notes:
- reproduced on all AMO servers
- not reproduced with FF release
- originally filed here: https://github.com/mozilla/addons-frontend/issues/4435

Comment 1

[Kumar McMillan [:kumar]]

We use InstallTrigger (https://developer.mozilla.org/en-US/docs/Web/API/InstallTrigger/install) on AMO but I disabled it locally and served a link directly to the XPI file -- I still saw the same problem.

Comment 2

[Andrew Swan [:aswan]]

This is a regression inadvertently created by bug 1431242, should be an easy fix and we should get it into 60.

Comment 3

[Andrew Swan [:aswan]]

Attachment: Bug 1442155 Fix extension names in Android install prompts

This is pretty short and sweet since everything goes through
_prepareStrings and in bug 1431242 Prathiksha standardized our
handling of the "header" string.

Review commit: https://reviewboard.mozilla.org/r/224788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224788/

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8955700 [details]
Bug 1442155 Fix extension names in Android install prompts

https://reviewboard.mozilla.org/r/224788/#review230936

Works for me, thank you for catching and fixing this!

Comment 5

[Mozilla Autoland]

hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Rev a2cac489d6f0 needs "Bug N" or "No bug" in the commit message.
remote: Andrew Swan <[e-mail]>
remote: 1442155 Fix extension names in Android install prompts r=johannh
remote: 
remote: This is pretty short and sweet since everything goes through
remote: _prepareStrings and in bug 1431242 Prathiksha standardized our
remote: handling of the "header" string.
remote: 
remote: MozReview-Commit-ID: 6t1kWmxVoyt
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_commitmessage hook failed
abort: push failed on remote

Comment 6

[Andrew Swan [:aswan]]

Comment on attachment 8955700 [details]
Bug 1442155 Fix extension names in Android install prompts

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224788/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/518c959486b0
Fix extension names in Android install prompts r=johannh

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/518c959486b0

Comment 9

[Andrew Swan [:aswan]]

Comment on attachment 8955700 [details]
Bug 1442155 Fix extension names in Android install prompts

Approval Request Comment
[Feature/Bug causing the regression]:
bug 1431242

[User impact if declined]:
Extension names are missing from install confirmation prompts

[Is this code covered by automated tests?]:
no

[Has the fix been verified in Nightly?]:
manually by the patch author, additional manual testing from QA would be good

[Needs manual test from QE? If yes, steps to reproduce]: 
covered in the bug

[List of other uplifts needed for the feature/fix]:
none

[Is the change risky?]:
no

[Why is the change risky/not risky?]:
the change is small and localized to the code that displays install-time permission prompts

[String changes made/needed]:
none

Comment 10

[Alexandra Moga [:LexaSV]]

Attachment: Fix - add-on name.jpg

Comment 11

[Alexandra Moga [:LexaSV]]

Verified as fixed with Firefox 60.0a1, Android 7.0 and 8.0.0

Comment 12

[Ryan VanderMeulen (PTO, back 6-April)]

Per Johann, this is a pretty bad issue.

Comment 13

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8955700 [details]
Bug 1442155 Fix extension names in Android install prompts

Let's get this fix into the 59 RC2. We want users to see what they're installing!

Comment 14

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/releases/mozilla-release/rev/ffa41479d180