1442231 - The yellow notification bar isn't displayed under the address bar instructing the user to clear stored site data or to continue

Status: RESOLVED INVALID

(Core :: Storage: Quota Manager, defect, P3)

Description

[Hani Yacoub, Desktop QA]

[Affected versions]:
Nightly 60.0a1

[Affected platforms]:
Windows 7 x32, Windows 10 x64

[Steps to reproduce]:
scenario 1: 
1. Access the following test page https://bug1377104.bmoattachments.org/attachment.cgi?id=8882153 and store >= 5G in persistent storage.
Note: to store data into Firefox click on "Persist me" button -> "Allow" and "Start adding data".

scenario 2: 
1. Go to about:config and set "browser.storageManager.pressureNotification.minIntervalMS" = 120000
2. Access the following test page https://bug1377104.bmoattachments.org/attachment.cgi?id=8882153 and store < 5G in persistent storage.

Note: to store data into Firefox click on "Persist me" button -> "Allow" and "Start adding data".


[Expected result]:
A yellow notification bar is displayed under the address bar instructing the user to clear stored site data.


[Actual result]:
The yellow notification bar is not displayed under the address bar instructing the user to clear stored site data or to continue.

[Note]:
On MacOS 10.12 the issue isn't reproducible only when using a fresh profile.
On Ubuntu 16.04 only the notification bar for under 5 GB witch indicates to continue adding data is displayed, and after clicking on "OK, Got it" nothing happens.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Hani, can you see if this is a regression using mozregression? That will give us a place to start looking into this.

Comment 2

[Johann Hofmann [:johannh]]

Sounds like a thing Quota Manager folks should look at.

Comment 3

[Marion Daly [:mdaly]]

:janv want to take a look?

Comment 4

[Hani Yacoub, Desktop QA]

Attachment: Notification.png

Friday when I tried to see if it's a regression I couldn't find any good build, and non of the notifications were displayed.
Today when I tried to do the same thing, on every build I tried the same notification appeared, only after the "Data added to indexeddb" reached 10000 MB or more the notification appeard. But the notification which should be displayed when the "Data added to indexeddb" is 5G or less was not displayed.

Comment 5

[Jan Varga [:janv]]

This is something that Tom could investigate.

Comment 6

[Tom Tung [:tt, :ttung]]

I'll investigate after finishing the initial steps for bug 1482662 (probably in a few days). Keep ni myself for noticing.

Comment 7

[Tom Tung [:tt, :ttung]]

Try to reproduce it as my initial step

Comment 8

[Jan Varga [:janv]]

I wonder how you figured out that 5G is the magic number. Quota manager fires the storage pressure notification when its storage is full. Size of the storage depends on initial free disk space, so it depends on concrete machine.
If you want to check storage pressure notifications in a reliable manner, you should use the "dom.quotaManager.temporaryStorage.fixedLimit" pref.
Tom can help you with that.

Comment 9

[Tom Tung [:tt, :ttung]]

(In reply to Hani Yacoub from comment #0)
Hi Hani,

Thanks for reporting this and the steps for reproducing! 

> [Steps to reproduce]:
> scenario 1: 
> 1. Access the following test page
> https://bug1377104.bmoattachments.org/attachment.cgi?id=8882153 and store >=
> 5G in persistent storage.
> Note: to store data into Firefox click on "Persist me" button -> "Allow" and
> "Start adding data".

Please correct me if I am wrong. IIRC, Firefox seems to notify users that while they are under a storage pressure event. In this scenario, I can't grab enough information to see Firefox should notify users about that. 

If your free disk space is less than a certain size, then you should get that while you are trying to add storage into Firefox. Could you tell me how much free disk space did your computer have so that you expect FF should show a notification? Or, could you show me why you expected to have a notification while there is a persistent storage and storing >= 5 G?

> scenario 2: 
> 1. Go to about:config and set
> "browser.storageManager.pressureNotification.minIntervalMS" = 120000
> 2. Access the following test page
> https://bug1377104.bmoattachments.org/attachment.cgi?id=8882153 and store <
> 5G in persistent storage.
> 
> Note: to store data into Firefox click on "Persist me" button -> "Allow" and
> "Start adding data".

So does this case.

> [Expected result]:
> A yellow notification bar is displayed under the address bar instructing the
> user to clear stored site data.
> 
> 
> [Actual result]:
> The yellow notification bar is not displayed under the address bar
> instructing the user to clear stored site data or to continue.
> 
> [Note]:
> On MacOS 10.12 the issue isn't reproducible only when using a fresh profile.
> On Ubuntu 16.04 only the notification bar for under 5 GB witch indicates to
> continue adding data is displayed, and after clicking on "OK, Got it"
> nothing happens.

So, in some cases, your FF shows that bar. The first thing comes to my mind is like what I mentioned. It seems to me there is another controlling factor (e.g. free spaces). It'd be really nice if you can provide me more information or show me the reason.

Comment 10

[Hani Yacoub, Desktop QA]

Attachment: notification.png

It has been a long time since I logged the bug. I figured out that 5G is the magic number form the documentation we received for this feature: (https://mozilla.invisionapp.com/share/4Y87EJO39#/screens/213203147)

The free disk space is around 7G, and I assume only when it gets closer to that number the first notification appears and it is not related to the 5G displayed in the documentation.

Now in my case Data added to indexeddb stopped at 7415 MB and the yellow notification is displayed as in the screenshot attached.
Hope this helps.

Comment 11

[Tom Tung [:tt, :ttung]]

(In reply to Hani Yacoub from comment #10)
> Created attachment 9003140 [details]
> notification.png
> 
> It has been a long time since I logged the bug. I figured out that 5G is the
> magic number form the documentation we received for this feature:
> (https://mozilla.invisionapp.com/share/4Y87EJO39#/screens/213203147)
> 
> The free disk space is around 7G, and I assume only when it gets closer to
> that number the first notification appears and it is not related to the 5G
> displayed in the documentation.
> 
> Now in my case Data added to indexeddb stopped at 7415 MB and the yellow
> notification is displayed as in the screenshot attached.
> Hope this helps.

Thanks for explaining!

The 5G in [1] represents the how much space is occupied by FF (more precisely: storage under QuotaManager) while receiving a storage pressure event. If the FF is using more than 5G, then we suggest users by asking them to clear their storage under FF. If not, we suggest them trying to optimize their disk usage. So, the number isn't related to when do you receive a notification bar for storage pressure, but is related to which kinds of bar you would see.

In comment 10, the behavior does meet the expectation, because the FF occupied 7415 MB and the bar is shown as [1].

[1] https://mozilla.invisionapp.com/share/4Y87EJO39#/screens/213203147

Comment 12

[Tom Tung [:tt, :ttung]]

Base on comment 11, and the attachment in both comment 0 behaved as [1] (it showed that bar [1] with UI showed that that origin occupied >= 5 G) and comment 10, I'm going to close this issue.

[1] https://mozilla.invisionapp.com/share/4Y87EJO39#/screens/213203147