Closed Bug 1442246 Opened 2 years ago Closed 2 years ago

Copy less URLs on stylo.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

I believe with these changes all the URL values in a single document are created with the same kind of string, and we can remove the mutable mIsUsingRustString stuff. But that'll be another bug.
Comment on attachment 8955135 [details]
Bug 1442246: Copy less URLs on stylo.

https://reviewboard.mozilla.org/r/224292/#review230264


Code analysis found 1 defect in this patch:
 - 1 defect found by clang-tidy

You can run this analysis locally with:
 - `./mach static-analysis check path/to/file.cpp` (C/C++)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: layout/style/nsCSSValue.h:235
(Diff revision 1)
>             nsIPrincipal* aOriginPrincipal);
>    URLValue(nsIURI* aURI, const nsAString& aString, nsIURI* aBaseURI,
>             nsIURI* aReferrer, nsIPrincipal* aOriginPrincipal);
>  
>    // This constructor is safe to call from any thread.
> -  URLValue(const nsAString& aString,
> +  URLValue(ServoRawOffsetArc<RustString> aString,

Error: Bad implicit conversion constructor for 'urlvalue' [clang-tidy: mozilla-implicit-constructor]
Depends on: 1442318
Comment on attachment 8955135 [details]
Bug 1442246: Copy less URLs on stylo.

https://reviewboard.mozilla.org/r/224292/#review230744
Attachment #8955135 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/0fd862d02af3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Assignee: nobody → emilio
You need to log in before you can comment on or make changes to this bug.