1442246 - Copy less URLs on stylo.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

I believe with these changes all the URL values in a single document are created with the same kind of string, and we can remove the mutable mIsUsingRustString stuff. But that'll be another bug.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1442246: Copy less URLs on stylo.

Review commit: https://reviewboard.mozilla.org/r/224292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224292/

Comment 2

[Code Review Bot [:reviewbot]]

Comment on attachment 8955135 [details]
Bug 1442246: Copy less URLs on stylo.

https://reviewboard.mozilla.org/r/224292/#review230264


Code analysis found 1 defect in this patch:
 - 1 defect found by clang-tidy

You can run this analysis locally with:
 - `./mach static-analysis check path/to/file.cpp` (C/C++)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: layout/style/nsCSSValue.h:235
(Diff revision 1)
>             nsIPrincipal* aOriginPrincipal);
>    URLValue(nsIURI* aURI, const nsAString& aString, nsIURI* aBaseURI,
>             nsIURI* aReferrer, nsIPrincipal* aOriginPrincipal);
>  
>    // This constructor is safe to call from any thread.
> -  URLValue(const nsAString& aString,
> +  URLValue(ServoRawOffsetArc<RustString> aString,

Error: Bad implicit conversion constructor for 'urlvalue' [clang-tidy: mozilla-implicit-constructor]

Comment 3

[Josh Matthews [:jdm]]

Comment on attachment 8955135 [details]
Bug 1442246: Copy less URLs on stylo.

https://reviewboard.mozilla.org/r/224292/#review230744

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fd862d02af3
Copy less URLs on stylo. r=jdm

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0fd862d02af3