1442295 - Add a few missing includes

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Andrew McCreight [:mccr8]]

As part of bug 1438688, I am generating a very simple .cpp file with only a few includes. This revealed two missing includes: nsTArray.h needs mozalloc.h for moz_xmalloc and nsTStringRepr.h needs fallible.h for fallible.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Add two missing includes in XPCOM.

Comment 2

[Eric Rahm [:erahm]]

Comment on attachment 8955261 [details] [diff] [review]
Add two missing includes in XPCOM.

Review of attachment 8955261 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/ds/nsTArray.h
@@ +17,5 @@
>  #include "mozilla/fallible.h"
>  #include "mozilla/MathAlgorithms.h"
>  #include "mozilla/MemoryReporting.h"
>  #include "mozilla/Move.h"
> +#include "mozilla/mozalloc.h"

I guess this should be before 'Move'

Comment 3

[Andrew McCreight [:mccr8]]

(In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment #2)
> >  #include "mozilla/Move.h"
> > +#include "mozilla/mozalloc.h"
> 
> I guess this should be before 'Move'

Why is that? Isn't it alphabetical?

Comment 4

[Eric Rahm [:erahm]]

(In reply to Andrew McCreight [:mccr8] from comment #3)
> (In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment
> #2)
> > >  #include "mozilla/Move.h"
> > > +#include "mozilla/mozalloc.h"
> > 
> > I guess this should be before 'Move'
> 
> Why is that? Isn't it alphabetical?

Oh right that's a z not a v.

Comment 5

[Andrew McCreight [:mccr8]]

This builds fine on OSX, but I'm seeing some weirdness on Linux with my other patches, so I want to make sure it builds there, too.

Comment 6

[Andrew McCreight [:mccr8]]

Linux was fine. The build problem I was seeing is unrelated to this patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6384f3478169
Add two missing includes in XPCOM. r=erahm

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/6384f3478169