--in-content-category-background is defined but never referenced

RESOLVED FIXED in Firefox 61

Status

()

P5
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jaws, Assigned: brianf.luk, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 61
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Priority: -- → P5

Updated

a year ago
Keywords: good-first-bug
Bug 1441882 added a test that catches these types of errors. When fixing this, the entry for this bug will need to be removed from the whitelist in browser_parsable_css.js.
(Assignee)

Comment 2

a year ago
Hi, I am new here, could I work on this as my first bug?
Go ahead. :) Have you built Firefox yet? Do you know what files to modify and
how to submit a patch?
(Assignee)

Comment 4

a year ago
Thanks for the quick reply! And yep, I have built Firefox on my VM. Should I be editing preferences.inc.css or browser_parsable_css.js? I've tried preferences.inc.css as it was the original post. I've also looked at some of the documentation for submitting a patch.
You will have to edit both of those files, since browser_parsable_css.js has a whitelist entry for it that will need to be removed once you remove the value from the preferences.inc.css file.
(Assignee)

Comment 6

a year ago
Posted patch 1442300.patchSplinter Review
Hi, I have posted a patch. Can you review it please?
Attachment #8958255 - Flags: review?(jaws)
Comment on attachment 8958255 [details] [diff] [review]
1442300.patch

Review of attachment 8958255 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Can you please export your changes? This diff is missing your author line which will give you proper attribution.

You should follow the steps at https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html to configure your machine to use MozReview, then you can use the steps at https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html to push this patch to MozReview. From there I can review it again and push your changes to our autoland repository (where it will eventually get merged to mozilla-central).

This is a bit of upfront work but it will make submitting your future patches much easier.
Attachment #8958255 - Flags: review?(jaws) → review+
Assignee: nobody → brianf.luk
Status: NEW → ASSIGNED

Comment 8

a year ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebffbbe870e5
Remove --in-content-category-background property since it is unused. r=jaws
I've pushed your patch for you. There shouldn't be any more work necessary for this bug. I will keep my eyes out for another bug that you can work on :)

Thanks!

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ebffbbe870e5
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.