Closed
Bug 1442300
Opened 7 years ago
Closed 7 years ago
--in-content-category-background is defined but never referenced
Categories
(Firefox :: Settings UI, defect, P5)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jaws, Assigned: brianf.luk, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
1.50 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
The property is defined at https://searchfox.org/mozilla-central/rev/769222fadff46164f8cc0dc7a0bae5a60dc2f335/browser/themes/shared/incontentprefs/preferences.inc.css#13 but never referenced.
Updated•7 years ago
|
Priority: -- → P5
Updated•7 years ago
|
Keywords: good-first-bug
Reporter | ||
Comment 1•7 years ago
|
||
Bug 1441882 added a test that catches these types of errors. When fixing this, the entry for this bug will need to be removed from the whitelist in browser_parsable_css.js.
Reporter | ||
Comment 3•7 years ago
|
||
Go ahead. :) Have you built Firefox yet? Do you know what files to modify and
how to submit a patch?
Thanks for the quick reply! And yep, I have built Firefox on my VM. Should I be editing preferences.inc.css or browser_parsable_css.js? I've tried preferences.inc.css as it was the original post. I've also looked at some of the documentation for submitting a patch.
Reporter | ||
Comment 5•7 years ago
|
||
You will have to edit both of those files, since browser_parsable_css.js has a whitelist entry for it that will need to be removed once you remove the value from the preferences.inc.css file.
Reporter | ||
Updated•7 years ago
|
Mentor: jaws
Hi, I have posted a patch. Can you review it please?
Attachment #8958255 -
Flags: review?(jaws)
Reporter | ||
Comment 7•7 years ago
|
||
Comment on attachment 8958255 [details] [diff] [review]
1442300.patch
Review of attachment 8958255 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Can you please export your changes? This diff is missing your author line which will give you proper attribution.
You should follow the steps at https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html to configure your machine to use MozReview, then you can use the steps at https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html to push this patch to MozReview. From there I can review it again and push your changes to our autoland repository (where it will eventually get merged to mozilla-central).
This is a bit of upfront work but it will make submitting your future patches much easier.
Attachment #8958255 -
Flags: review?(jaws) → review+
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → brianf.luk
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebffbbe870e5
Remove --in-content-category-background property since it is unused. r=jaws
Reporter | ||
Comment 9•7 years ago
|
||
I've pushed your patch for you. There shouldn't be any more work necessary for this bug. I will keep my eyes out for another bug that you can work on :)
Thanks!
Comment 10•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•