Closed Bug 1442300 Opened 4 years ago Closed 4 years ago

--in-content-category-background is defined but never referenced


(Firefox :: Preferences, defect, P5)




Firefox 61
Tracking Status
firefox61 --- fixed


(Reporter: jaws, Assigned: brianf.luk, Mentored)



(Keywords: good-first-bug)


(1 file)

Priority: -- → P5
Keywords: good-first-bug
Bug 1441882 added a test that catches these types of errors. When fixing this, the entry for this bug will need to be removed from the whitelist in browser_parsable_css.js.
Hi, I am new here, could I work on this as my first bug?
Go ahead. :) Have you built Firefox yet? Do you know what files to modify and
how to submit a patch?
Thanks for the quick reply! And yep, I have built Firefox on my VM. Should I be editing or browser_parsable_css.js? I've tried as it was the original post. I've also looked at some of the documentation for submitting a patch.
You will have to edit both of those files, since browser_parsable_css.js has a whitelist entry for it that will need to be removed once you remove the value from the file.
Mentor: jaws
Attached patch 1442300.patchSplinter Review
Hi, I have posted a patch. Can you review it please?
Attachment #8958255 - Flags: review?(jaws)
Comment on attachment 8958255 [details] [diff] [review]

Review of attachment 8958255 [details] [diff] [review]:

Looks good. Can you please export your changes? This diff is missing your author line which will give you proper attribution.

You should follow the steps at to configure your machine to use MozReview, then you can use the steps at to push this patch to MozReview. From there I can review it again and push your changes to our autoland repository (where it will eventually get merged to mozilla-central).

This is a bit of upfront work but it will make submitting your future patches much easier.
Attachment #8958255 - Flags: review?(jaws) → review+
Assignee: nobody → brianf.luk
Pushed by
Remove --in-content-category-background property since it is unused. r=jaws
I've pushed your patch for you. There shouldn't be any more work necessary for this bug. I will keep my eyes out for another bug that you can work on :)

Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.