Remove dead onremovestream code

RESOLVED FIXED in Firefox 60

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bwc, Assigned: bwc)

Tracking

({dev-doc-complete, site-compat})

60 Branch
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

a year ago
Keywords: dev-doc-needed
(Assignee)

Updated

a year ago
Version: 59 Branch → 60 Branch
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8955298 [details]
Bug 1442385: Remove old onremovestream event stuff.

https://reviewboard.mozilla.org/r/224450/#review230704

This removes the internal stuff, which is fine. I'm going to open a separate bug to try to get a deprecation warning on the webidl attribute for 59.
Attachment #8955298 - Flags: review?(jib) → review+
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 2 changes to 2 files
remote: 
remote: WebIDL file dom/webidl/PeerConnectionObserver.webidl altered in changeset b606f21906ed without DOM peer review
remote: 
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: 
remote: Changes to WebIDL files in this repo require review from a DOM peer in the form of r=...
remote: This is to ensure that we behave responsibly with exposing new Web APIs. We appreciate your understanding..
remote: 
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.d_webidl hook failed
abort: push failed on remote
(Assignee)

Updated

a year ago
Attachment #8955298 - Flags: review?(bugs)

Comment 4

a year ago
mozreview-review
Comment on attachment 8955298 [details]
Bug 1442385: Remove old onremovestream event stuff.

https://reviewboard.mozilla.org/r/224450/#review230856
Attachment #8955298 - Flags: review?(bugs) → review+

Comment 5

a year ago
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab959de6ec50
Remove old onremovestream event stuff. r=jib,smaug

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ab959de6ec50
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Submitted PR against BCD repository to update this in the compat tables: https://github.com/mdn/browser-compat-data/pull/1802; this has been merged and will go live on MDN next time the data is pulled over.

Made related updates to pages:

https://developer.mozilla.org/en-US/docs/Web/Events/removestream
https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrackEvent
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/onremovestream

And updated Firefox 60 for developers
You need to log in before you can comment on or make changes to this bug.