1442385 - Remove dead onremovestream code

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement)

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1442385: Remove old onremovestream event stuff.

Review commit: https://reviewboard.mozilla.org/r/224450/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224450/

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8955298 [details]
Bug 1442385: Remove old onremovestream event stuff.

https://reviewboard.mozilla.org/r/224450/#review230704

This removes the internal stuff, which is fine. I'm going to open a separate bug to try to get a deprecation warning on the webidl attribute for 59.

Comment 3

[Mozilla Autoland]

hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 2 changes to 2 files
remote: 
remote: WebIDL file dom/webidl/PeerConnectionObserver.webidl altered in changeset b606f21906ed without DOM peer review
remote: 
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: 
remote: Changes to WebIDL files in this repo require review from a DOM peer in the form of r=...
remote: This is to ensure that we behave responsibly with exposing new Web APIs. We appreciate your understanding..
remote: 
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.d_webidl hook failed
abort: push failed on remote

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8955298 [details]
Bug 1442385: Remove old onremovestream event stuff.

https://reviewboard.mozilla.org/r/224450/#review230856

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab959de6ec50
Remove old onremovestream event stuff. r=jib,smaug

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ab959de6ec50

Comment 7

[Eric Shepherd [:sheppy]]

Submitted PR against BCD repository to update this in the compat tables: https://github.com/mdn/browser-compat-data/pull/1802; this has been merged and will go live on MDN next time the data is pulled over.

Made related updates to pages:

https://developer.mozilla.org/en-US/docs/Web/Events/removestream
https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrackEvent
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/onremovestream

And updated Firefox 60 for developers

Comment 8

[Kohei Yoshino [:kohei]]

Posted the site compatibility note: https://www.fxsitecompat.com/ja/docs/2018/removestream-event-has-been-removed-from-rtcpeerconnection/

Comment 9

[Kohei Yoshino [:kohei]]

Er, English here: https://www.fxsitecompat.com/en-CA/docs/2018/removestream-event-has-been-removed-from-rtcpeerconnection/