1442451 - Previously opened devtools are not closed when disable devtools policy is in use

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect)

Description

[Abe - QA (:Abe_LV)]

Steps to reproduce:
screen capture- https://testing-1.tinytake.com/sf/MjQwMTgxNV83Mjg3MjUw

1.Start Nightly
2.Open browser console [Ctrl +Shift+J] , Developer tools [F12], and toolbar [Shift+F2]
3.Set "browser.policies.enabled" to true and use "DisableDeveloperTools":true policy.

4. Restart the browser
5. Verify if all tools opened in step 2 are closed/exited/

Actual result:
The user still has access to dev toolbar and browser console[some level].

Expected Result:
Previously opened dev tools should be closed upon a restart

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

SessionStore calls[1] DevToolsShim.restoreDevToolsSession unconditionally, which checks the shim pref but not the policy pref.

I imagine Julian has an opinion on how to proceed here.

[1]: https://searchfox.org/mozilla-central/rev/61d400da1c692453c2dc2c1cf37b616ce13dea5b/browser/components/sessionstore/SessionStore.jsm#2859

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Thanks Abe for finding it. This is an edge case that doesn't sound like a blocker, but I imagine the fix will be simple. I'll let Julian handle it.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1442451 - do not restore DevTools session when disabled by policy;

Review commit: https://reviewboard.mozilla.org/r/224594/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224594/

Comment 4

[Julian Descottes [:jdescottes]]

Good catch. We could either set the preference devtools.enabled to to false in devtools-startup in case devtools are disabled by policy, but for now I prefer to explicitly check this in the DevToolsShim. Hopefully we can reduce the complexity in Bug 1440675, but that should wait for the 61 cycle.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8955412 [details]
Bug 1442451 - do not restore DevTools session when disabled by policy;

https://reviewboard.mozilla.org/r/224594/#review230798

Thanks for working this! :) Looks reasonable to me.

Comment 6

[Julian Descottes [:jdescottes]]

Thanks for the review, try was green at https://treeherder.mozilla.org/#/jobs?repo=try&revision=f70274221d255bfa0feb7daded887ff4bf56d4fe

Landing.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c120740c252
do not restore DevTools session when disabled by policy;r=jryans

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2c120740c252

Comment 9

[Abe - QA (:Abe_LV)]

I retested this and it is verified as fixed. Previously opened devtools are now closed when 'disable devtools' policy is active