59 bytes, text/x-review-board-request
When looking at the scrollbar code for Bug 1431246 I found this method which doesn't appear to be called anywhere: https://searchfox.org/mozilla-central/search?q=GetScrollbarPressStates&path=
Comment on attachment 8955607 [details] Bug 1442695 - Remove unused GetScrollbarPressStates method; https://reviewboard.mozilla.org/r/224708/#review230734 Looks good to me. Could you please find out when we stopped using this method before landing, to make sure we didn't miss anything? Thanks!
Attachment #8955607 - Flags: review?(spohl.mozilla.bugs) → review+
I see a call in ESR 45 https://dxr.mozilla.org/mozilla-esr45/search?q=GetScrollbarPressStates but not ESR 52: https://dxr.mozilla.org/mozilla-esr52/search?q=GetScrollbarPressStates. Looks like it was guarded on !nsCocoaFeatures::OnLionOrLater https://dxr.mozilla.org/mozilla-esr45/source/widget/cocoa/nsNativeThemeCocoa.mm#2166.
Yeah, it became unused when we dropped support for 10.6 (which is the last version that had scrollbars with buttons).
2 years ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/304c6387dab2 Remove unused GetScrollbarPressStates method;r=spohl
You need to log in before you can comment on or make changes to this bug.