1442695 - Remove unused GetScrollbarPressStates method

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Description

[Brian Grinstead [:bgrins]]

When looking at the scrollbar code for Bug 1431246 I found this method which doesn't appear to be called anywhere: https://searchfox.org/mozilla-central/search?q=GetScrollbarPressStates&path=

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1442695 - Remove unused GetScrollbarPressStates method;

Review commit: https://reviewboard.mozilla.org/r/224708/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224708/

Comment 2

[Stephen A Pohl [:spohl]]

Comment on attachment 8955607 [details]
Bug 1442695 - Remove unused GetScrollbarPressStates method;

https://reviewboard.mozilla.org/r/224708/#review230734

Looks good to me. Could you please find out when we stopped using this method before landing, to make sure we didn't miss anything? Thanks!

Comment 3

[Brian Grinstead [:bgrins]]

I see a call in ESR 45 https://dxr.mozilla.org/mozilla-esr45/search?q=GetScrollbarPressStates but not ESR 52: https://dxr.mozilla.org/mozilla-esr52/search?q=GetScrollbarPressStates. Looks like it was guarded on !nsCocoaFeatures::OnLionOrLater https://dxr.mozilla.org/mozilla-esr45/source/widget/cocoa/nsNativeThemeCocoa.mm#2166.

Comment 4

[Markus Stange [:mstange]]

Yeah, it became unused when we dropped support for 10.6 (which is the last version that had scrollbars with buttons).

Comment 5

[Stephen A Pohl [:spohl]]

Great, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/304c6387dab2
Remove unused GetScrollbarPressStates method;r=spohl

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/304c6387dab2