1442795 - Simplify <scale> bindings

Status: RESOLVED FIXED

(Core :: XUL, task)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Still trying to figure out what we could do with the three bindings in scale.xml.

For scalethumb I think I can safely remove it.

For scaleslider as it extends basecontrol I need to look deeper.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1442795 - Remove scale-thumb and scale-slider bindings

Both bindings contain no content to be styled, and their own styles are applied by
<resources> import from the scale binding.

This patch also moves the binding rules from minimal-xul.css to xul.css, given that
while <scale> is used in <videocontrols>, HTML documents containing <video> or <audio>
will load the full xul.css.

Review commit: https://reviewboard.mozilla.org/r/224812/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224812/

Comment 2

[ExE Boss]

Since the scale-thumb and scale-slider are XBL bindings, this is blocking bug 1397874, rather than depending on it.

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8955727 [details]
Bug 1442795 - Remove scale-thumb and scale-slider bindings

https://reviewboard.mozilla.org/r/224812/#review230862

::: toolkit/content/xul.css:873
(Diff revision 1)
>    min-width: 0% ! important;
>    min-height: 0% ! important;
>    -moz-box-ordinal-group: 2147483646;
>  }
>  
> +/********** scale **************/

I believe we need to keep any styles (including those currently in scale.css) into minimal-xul.css so that it will be usable from the videocontrols binding (in HTML docs)

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #3)
> ::: toolkit/content/xul.css:873
> (Diff revision 1)
> >    min-width: 0% ! important;
> >    min-height: 0% ! important;
> >    -moz-box-ordinal-group: 2147483646;
> >  }
> >  
> > +/********** scale **************/
> 
> I believe we need to keep any styles (including those currently in
> scale.css) into minimal-xul.css so that it will be usable from the
> videocontrols binding (in HTML docs)

As we discussed - keeping them in xul.css is actually fine since we load that file into content in the case of videocontrols/touchcontrols

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Just to be on the safe side — I am going to manually test this out on Fennec before asking for review.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #5)
> Just to be on the safe side — I am going to manually test this out on Fennec
> before asking for review.

I can verify that the slider still works OK on Fennec.

Comment 7

[Neil Deakin]

Comment on attachment 8955727 [details]
Bug 1442795 - Remove scale-thumb and scale-slider bindings

https://reviewboard.mozilla.org/r/224812/#review231678

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cff47a58fcb6
Remove scale-thumb and scale-slider bindings r=enndeakin+6102

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/cff47a58fcb6