Simplify <scale> bindings

RESOLVED FIXED in Firefox 60

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

(Blocks: 1 bug)

59 Branch
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

Still trying to figure out what we could do with the three bindings in scale.xml.

For scalethumb I think I can safely remove it.

For scaleslider as it extends basecontrol I need to look deeper.
Comment hidden (mozreview-request)

Comment 2

a year ago
Since the scale-thumb and scale-slider are XBL bindings, this is blocking bug 1397874, rather than depending on it.
Blocks: 1397874
No longer depends on: 1397874

Comment 3

a year ago
mozreview-review
Comment on attachment 8955727 [details]
Bug 1442795 - Remove scale-thumb and scale-slider bindings

https://reviewboard.mozilla.org/r/224812/#review230862

::: toolkit/content/xul.css:873
(Diff revision 1)
>    min-width: 0% ! important;
>    min-height: 0% ! important;
>    -moz-box-ordinal-group: 2147483646;
>  }
>  
> +/********** scale **************/

I believe we need to keep any styles (including those currently in scale.css) into minimal-xul.css so that it will be usable from the videocontrols binding (in HTML docs)
(In reply to Brian Grinstead [:bgrins] from comment #3)
> ::: toolkit/content/xul.css:873
> (Diff revision 1)
> >    min-width: 0% ! important;
> >    min-height: 0% ! important;
> >    -moz-box-ordinal-group: 2147483646;
> >  }
> >  
> > +/********** scale **************/
> 
> I believe we need to keep any styles (including those currently in
> scale.css) into minimal-xul.css so that it will be usable from the
> videocontrols binding (in HTML docs)

As we discussed - keeping them in xul.css is actually fine since we load that file into content in the case of videocontrols/touchcontrols
Just to be on the safe side — I am going to manually test this out on Fennec before asking for review.
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #5)
> Just to be on the safe side — I am going to manually test this out on Fennec
> before asking for review.

I can verify that the slider still works OK on Fennec.

Comment 7

a year ago
mozreview-review
Comment on attachment 8955727 [details]
Bug 1442795 - Remove scale-thumb and scale-slider bindings

https://reviewboard.mozilla.org/r/224812/#review231678
Attachment #8955727 - Flags: review?(enndeakin) → review+

Comment 8

a year ago
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cff47a58fcb6
Remove scale-thumb and scale-slider bindings r=enndeakin+6102

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cff47a58fcb6
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.