1442867 - stylo-chrome: Close button [x] on all Tabs is blacked out (gfx.font_rendering.opentype_svg.enabled;false)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[suool]

Attachment: FF_Black Tabs.JPG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180303100406

Steps to reproduce:

No need to do something special happens after you start FF.


Actual results:

Close button from every tab is blacked out. Happened after a nightly update is still consists. 


Expected results:

The close button [x] should be shown on every tab

Comment 1

[Gingerbread Man]

Probable duplicate of bug 1442864.

1. Please enter about:support into the location bar. Click the "Copy text to clipboard" button. Paste the clipboard contents into a text editor like Notepad. Save the file, then click the "Attach File" link on this page, above the description.

2. Please try to find the regression range if you can.
http://mozilla.github.io/mozregression/quickstart.html

Comment 2

[suool]

Attachment: About_support_FF.txt

Could not find the build it started. All looked good with mozregression.

Comment 3

[Gingerbread Man]

(In reply to suool from comment #2)
> About_support_FF.txt

Thank you. It looks like webrender isn't enabled after all, so there goes that theory.

> Could not find the build it started. All looked good with mozregression.

Did you specify your normal profile? By default, mozregression uses a brand new profile. If the latter is okay, the problem might be some form of user customization, like a modified preference, userChrome.css, or add-ons.

Comment 4

[suool]

(In reply to Gingerbread Man from comment #3)
> (In reply to suool from comment #2)
> > About_support_FF.txt
> 
> Thank you. It looks like webrender isn't enabled after all, so there goes
> that theory.
> 
I found it was gfx.font_rendering.opentype_svg.enabled;false

But I changed that some time ago and it worked. Suddenly with a new nightly build it changed. 

Any idea on that? The black boxes are gone setting the value to true.

Thank you for your help!

Comment 5

[Darkspirit]

Debian Testing (KDE, Radeon RX480)
I can reproduce and it looks the same as in attachment 8955763 [details].

mozregression --good 2018-01-01 --bad 2018-03-03 --pref gfx.font_rendering.opentype_svg.enabled:false
> 8:31.81 INFO: Last good revision: 7f2dd59744eb4041bc5de60657d931d1a2e9859a
> 8:31.81 INFO: First bad revision: 7a63a457c8e89edc417ea384f24102c988feb3d5
> 8:31.81 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7f2dd59744eb4041bc5de60657d931d1a2e9859a&tochange=7a63a457c8e89edc417ea384f24102c988feb3d5

(2018-02-20)
> 7a63a457c8e8	Xidorn Quan — Bug 1417138 part 2 - Enable stylo-chrome by default. r=bholley
> 1f08bf9a7a50	Xidorn Quan — Bug 1417138 part 1 - Skip about:downloads in about url test. r=Gijs

Comment 6

[Darkspirit]

https://privacy-handbuch.de/handbuch_21u.htm suggests to set gfx.font_rendering.opentype_svg.enabled;false, for example.

Comment 7

[Darkspirit]

Oops.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Hmm... I think I see what's going wrong.

Comment 9

[Xidorn Quan [:xidorn] UTC+11]

I... don't see what's going wrong... Or, I see how it's going wrong, but I don't see how it doesn't in Gecko...

Comment 10

[Emilio Cobos Álvarez (:emilio)]

https://github.com/servo/servo/pull/20190

Comment 11

[Emilio Cobos Álvarez (:emilio)]

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #9)
> I... don't see what's going wrong... Or, I see how it's going wrong, but I
> don't see how it doesn't in Gecko...

Bug 1365926 stoped gating those keywords with the opentype-in-svg pref, but there was never a stylo version of that, nor tests...

Comment 12

[Xidorn Quan [:xidorn] UTC+11]

Ah... How broken the whole thing is... I'm wondering whether we should just remove that pref...

Comment 13

[suool]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #6)
> https://privacy-handbuch.de/handbuch_21u.htm suggests to set
> gfx.font_rendering.opentype_svg.enabled;false, for example.

Yep, that´s why i disabled it.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

https://hg.mozilla.org/mozilla-central/rev/1fb5d2d675ab178768684c668e053a4763d37c5f