Closed Bug 1442938 Opened 5 years ago Closed 5 years ago
nil-check the window title when saving / restoring window state
59 bytes, text/x-review-board-request
Looking at the docs for [NSWindow title] I don't think it's supposed to return nil under any circumstances... But it does in our automation, for some reason, with the patches for bug 1439875 which make our fullscreen code run a bit earlier.
Why does fullscreen code run during startup at all? I don't expect it happens...
(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #1) > Why does fullscreen code run during startup at all? I don't expect it > happens... It's not on browser startup, fwiw. Fullscreen relies on hidechrome, which is reflected from the <window hidechrome> attribute in nsXULWindow::SyncAttributesToWidget. Which with the patch from bug 1439875 runs before layout and not on window load.
Comment on attachment 8955842 [details] Bug 1442938: Nil-check the title in nsCocoaWindow::importState / exportState. https://reviewboard.mozilla.org/r/224866/#review231756 Yeah, not sure why this would happen, but this extra check can't really break anything else, so let's add it.
Attachment #8955842 - Flags: review?(mstange) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4b56d0a2859f Nil-check the title in nsCocoaWindow::importState / exportState. r=mstange
You need to log in before you can comment on or make changes to this bug.