1442938 - nil-check the window title when saving / restoring window state.

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Looking at the docs for [NSWindow title] I don't think it's supposed to return nil under any circumstances...

But it does in our automation, for some reason, with the patches for bug 1439875 which make our fullscreen code run a bit earlier.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Why does fullscreen code run during startup at all? I don't expect it happens...

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1442938: Nil-check the title in nsCocoaWindow::importState / exportState.

Review commit: https://reviewboard.mozilla.org/r/224866/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224866/

Comment 3

[Emilio Cobos Álvarez [:emilio]]

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #1)
> Why does fullscreen code run during startup at all? I don't expect it
> happens...

It's not on browser startup, fwiw.

Fullscreen relies on hidechrome, which is reflected from the <window hidechrome> attribute in nsXULWindow::SyncAttributesToWidget. Which with the patch from bug 1439875 runs before layout and not on window load.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8955842 [details]
Bug 1442938: Nil-check the title in nsCocoaWindow::importState / exportState.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224866/diff/1-2/

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8955842 [details]
Bug 1442938: Nil-check the title in nsCocoaWindow::importState / exportState.

https://reviewboard.mozilla.org/r/224866/#review231756

Yeah, not sure why this would happen, but this extra check can't really break anything else, so let's add it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b56d0a2859f
Nil-check the title in nsCocoaWindow::importState / exportState. r=mstange

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4b56d0a2859f