1442997 - Disable favicons still newtabpage show icon in Firefox60(esr branch)

Status: REOPENED

(Firefox :: General, defect, P5)

Description

[u601173]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180304102248

Steps to reproduce:

Like above disable favicons,
restart,
open a blank tab,
icon is shown

Comment 1

[Tim Spurway [:tspurway]]

:hulmelo can you go through how you disable favicons?

Comment 2

[u601173]

(In reply to Tim Spurway [:tspurway] from comment #1)
> :hulmelo can you go through how you disable favicons?

browser.chrome.favicons
browser.chrome.site_icons

Comment 3

[Tim Spurway [:tspurway]]

Those prefs aren't meant to control the images on the newtab page

Comment 4

[u601173]

Attachment: The issue

(In reply to Tim Spurway [:tspurway] from comment #3)
> Those prefs aren't meant to control the images on the newtab page

Images?

Meant the icon!

Comment 5

[u601173]

Ni for comment [e-mail]

Comment 6

[u601173]

Oops for comment 4
please ignore comment 5

Comment 7

[Ed Lee :Mardak]

This might have been caused by bug 1401955. Where `setIcon` is called directly to avoid flashing

https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/browser/base/content/tabbrowser.js#778

But maybe it should check `shouldLoadFavicon` first?

https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/browser/base/content/tabbrowser.js#818-821

Where that method might get cleaned up in removing one of those two prefs in bug 1423993.

Comment 8

[Johann Hofmann [:johannh]]

That doesn't seem particularly important to me (it may be wontfix), since these prefs are not exposed via preferences UI AFAIK.

Comment 9

[u595893]

(In reply to Johann Hofmann [:johannh] from comment #8)
> That doesn't seem particularly important to me (it may be wontfix), since
> these prefs are not exposed via preferences UI AFAIK.

with Windows Group Policy Support this is a must for enterprises and next ESR60 will be released soon
So P5 or won't fix seems odd as this is a legitimate bug

Comment 10

[Johann Hofmann [:johannh]]

(In reply to u595893 from comment #9)
> (In reply to Johann Hofmann [:johannh] from comment #8)
> > That doesn't seem particularly important to me (it may be wontfix), since
> > these prefs are not exposed via preferences UI AFAIK.
> 
> with Windows Group Policy Support this is a must for enterprises and next
> ESR60 will be released soon
> So P5 or won't fix seems odd as this is a legitimate bug

Ah, if this is a legitimate concern for enterprise policies I'm happy to help resolve it.

Felipe, can you help categorize the priority/urgency for this?

Thanks!

Comment 11

[:Felipe Gomes (needinfo for replies!)]

We don't a policy through GPO to disable favicons*, so it's not of immediate concern. Having said that, ESR 60 will continue to support Autoconfig, so it'll remain possible to change these prefs through that, and more people might be interested in Firefox deployments now.


* (we could accept a patch if someone writes it)